fix(OnyxMobileNavButton): scroll on overflowing mobile flyout #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bcc4e0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: BoppLi <[email protected]>
BoppLi
changed the title
BoppLi
changed the title
BoppLi
changed the title
larsrickert
previously requested changes
Jul 10, 2024
...nyx/playwright/snapshots/components/OnyxMobileNavButton/Mobile-nav-button-chromium-linux.png
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxMobileNavButton/OnyxMobileNavButton.vue
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxMobileNavButton/OnyxMobileNavButton.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxMobileNavButton/OnyxMobileNavButton.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxNavBar/modules/OnyxUserMenu/OnyxUserMenu.vue
Outdated
Show resolved
Hide resolved
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: BoppLi <[email protected]>
Co-authored-by: Lars Rickert <[email protected]>
Co-authored-by: Lars Rickert <[email protected]>
…chwarzIT/onyx into fix/1483-max-scrolling-nav-bar
larsrickert
requested changes
Jul 11, 2024
packages/sit-onyx/src/components/OnyxMobileNavButton/OnyxMobileNavButton.ct.tsx
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxMobileNavButton/OnyxMobileNavButton.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxNavBar/OnyxNavBar.stories.ts
Outdated
Show resolved
Hide resolved
…eNavButton.ct.tsx Co-authored-by: Lars Rickert <[email protected]>
Co-authored-by: Lars Rickert <[email protected]>
…chwarzIT/onyx into fix/1483-max-scrolling-nav-bar
larsrickert
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1483
The flyout of OnyxMobileNavButton now has a max height and is scrollable if too many nav/context items exist.
Checklist
npx changeset addif your changes should be released as npm package (because they affect the library usage)