Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grid): include padding in max-width and align with nav bar #1120

Merged
merged 7 commits into from
May 17, 2024

Conversation

larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented May 17, 2024

Relates to #867, #867 (comment)

After a talk with @jannick-ux we came to the conclusion that:

  • width in Figma are meant to include the padding so if grid max width is 1440px, the actual component width is 1312px so in total: 1312px width + 2 * 64px padding = 1440px.

What I did:

  • fix grid to use box-sizing: border-box; instead of content-box
  • add screenshot tests which shows a full app layout with nav bar and page content to test that both are aligned with each other
  • add grid demo page to the alpha demo app so we can play around with it and see it in action

Checklist

  • The added / edited code has been documented with JSDoc
  • If a new component is added, at least one Playwright screenshot test is added
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

larsrickert and others added 4 commits May 17, 2024 11:21
This is an auto-generated pull request. All Playwright screenshots have
been updated.

Co-authored-by: larsrickert <[email protected]>
Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: 4993d72

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
sit-onyx Patch
alpha-test-app Patch
playground Patch
@sit-onyx/chartjs-plugin Patch
@sit-onyx/storybook-utils Patch
@sit-onyx/vitepress-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@larsrickert larsrickert marked this pull request as ready for review May 17, 2024 09:58
@larsrickert larsrickert requested a review from a team as a code owner May 17, 2024 09:58
@larsrickert larsrickert merged commit c011e27 into main May 17, 2024
19 checks passed
@larsrickert larsrickert deleted the fix/867-nav-bar-padding branch May 17, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants