Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept NavItem disabled state #1862

Closed
1 task
mj-hof opened this issue Sep 12, 2024 Discussed in #1837 · 3 comments
Closed
1 task

Concept NavItem disabled state #1862

mj-hof opened this issue Sep 12, 2024 Discussed in #1837 · 3 comments
Assignees
Labels
ux Requires UX/UI design

Comments

@mj-hof
Copy link
Collaborator

mj-hof commented Sep 12, 2024

Discussed in #1837

  • Check if an additional info, like tooltip, is needed to give user enough info why item is disabled
@mj-hof mj-hof added the ux Requires UX/UI design label Sep 12, 2024
@mj-hof mj-hof added this to the Navigation bars milestone Sep 12, 2024
@mj-hof mj-hof added this to onyx Sep 12, 2024
@github-project-automation github-project-automation bot moved this to New in onyx Sep 12, 2024
@mj-hof mj-hof added the 0-refinement All issues that can or need to be estimated in our next refinement label Nov 27, 2024
@mj-hof mj-hof moved this from New to Backlog in onyx Nov 27, 2024
@mj-hof mj-hof moved this from Backlog to Ready in onyx Nov 27, 2024
@mj-hof mj-hof removed the 0-refinement All issues that can or need to be estimated in our next refinement label Nov 27, 2024
@flubnau flubnau moved this from Ready to In Progress in onyx Nov 28, 2024
@flubnau
Copy link
Collaborator

flubnau commented Nov 29, 2024

As if a tooltip does not work on keyboard Navigation, because an disabled button could not be focused it won't work on that use case. Same for Touch usage.

But if you use only the keyboard, there’s no way of seeing that tooltip because the button cannot be focused with disabled. The same thing happens in touch devices too. Ouch!

@flubnau flubnau moved this from In Progress to In Approval in onyx Nov 29, 2024
@flubnau flubnau moved this from In Approval to Done in onyx Dec 4, 2024
@mj-hof mj-hof closed this as completed Dec 6, 2024
@Sinan-SchwarzIT
Copy link

Hi @mj-hof, is this feature implemented or planned? I haven't seen a disabled property so far :-)

@larsrickert
Copy link
Collaborator

@Sinan-SchwarzIT The disabled state is concepted from UX in Figma but we have to implement it technically in #2238.
I marked the ticket for refinement so we will talk about it in our next refinement meeting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux Requires UX/UI design
Projects
Status: Done
Development

No branches or pull requests

6 participants