Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OnyxNavItem List inaccessible #1054

Closed
14 tasks
JoCa96 opened this issue May 8, 2024 · 0 comments
Closed
14 tasks

Fix OnyxNavItem List inaccessible #1054

JoCa96 opened this issue May 8, 2024 · 0 comments
Assignees
@JoCa96
Labels
dev Requires technical expertise
Milestone
Navigation bars

Comments

@JoCa96
Copy link
Collaborator

JoCa96 commented May 8, 2024 •
edited
Loading

Depends on

Why?

The list in the OnyxNavItem is missing necessary aria roles and interaction patterns.

Design

Figma

Acceptance criteria

Definition of Done

  • The following component requirements are implemented:
    • skeleton
    • density
    • example usage added to apps/alpha-test-app/src/views/HomeView.vue
  • covered by component tests
  • screenshot tests are updated
  • follow-up tickets were created if necessary
  • updated version + documentation is deployed
  • Storybook can show the feature
  • Set task to In Approval

Approval

  • Storybook
  • Deployed Docs
  • approved by designer @jannick-ux
  • approved by dev

Implementation details

Reference implementations

Applicable ARIA Pattern
@JoCa96 JoCa96 added this to onyx May 8, 2024
@JoCa96 JoCa96 converted this from a draft issue May 8, 2024
@JoCa96 JoCa96 self-assigned this May 8, 2024
@JoCa96 JoCa96 moved this from New to Backlog in onyx May 8, 2024
@JoCa96 JoCa96 added the dev Requires technical expertise label May 8, 2024
@JoCa96 JoCa96 added this to the Navigation bars milestone May 8, 2024
@mj-hof mj-hof closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in onyx Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoCa96 JoCa96

Labels
dev Requires technical expertise
Projects
onyx
Archived in project
Milestone
Navigation bars
Development

No branches or pull requests
2 participants
@JoCa96 @mj-hof