From f46561c94ea4a575937e9f35f24cc8b4a4f236f7 Mon Sep 17 00:00:00 2001 From: Jonathan Date: Fri, 24 May 2024 16:43:34 +0200 Subject: [PATCH] chore: Rename and move OnyxSelect (#1165) Relates to #565 Renamed `OnyxSelect` component to `OnyxSelectInput` in preparation for the new `OnyxSelect` component. The `OnyxSelectInput` is only responsible for rendering the selected value(s) and handling focus. Therefore, the `modelValue` prop was renamed to `selection` to better communicate that it only does One-Way binding. --------- Co-authored-by: Lars Rickert Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: JoCa96 <18483883+JoCa96@users.noreply.github.com> --- .changeset/eleven-sheep-fry.md | 5 + apps/alpha-test-app/src/views/HomeView.vue | 14 +- .../src/components/VersionSelect.vue | 4 +- .../Select-default--chromium-linux.png | Bin 26270 -> 0 bytes .../Select-default--firefox-linux.png | Bin 33701 -> 0 bytes .../Select-default--webkit-linux.png | Bin 20409 -> 0 bytes .../Select-multiple--chromium-linux.png | Bin 36458 -> 0 bytes .../Select-multiple--firefox-linux.png | Bin 43466 -> 0 bytes .../Select-multiple--webkit-linux.png | Bin 29830 -> 0 bytes .../Select-other--chromium-linux.png | Bin 25420 -> 0 bytes .../Select-other--firefox-linux.png | Bin 30667 -> 0 bytes .../OnyxSelect/Select-other--webkit-linux.png | Bin 19042 -> 0 bytes .../Select-placeholder--chromium-linux.png | Bin 33242 -> 0 bytes .../Select-placeholder--firefox-linux.png | Bin 40856 -> 0 bytes .../Select-placeholder--webkit-linux.png | Bin 26614 -> 0 bytes ...donly-disabled-loading--chromium-linux.png | Bin 35636 -> 0 bytes ...adonly-disabled-loading--firefox-linux.png | Bin 44769 -> 0 bytes ...eadonly-disabled-loading--webkit-linux.png | Bin 29773 -> 0 bytes .../Select-skeleton--chromium-linux.png | Bin 17206 -> 0 bytes .../Select-skeleton--firefox-linux.png | Bin 22323 -> 0 bytes .../Select-skeleton--webkit-linux.png | Bin 12465 -> 0 bytes .../Select-with-value--chromium-linux.png | Bin 32583 -> 0 bytes .../Select-with-value--firefox-linux.png | Bin 40193 -> 0 bytes .../Select-with-value--webkit-linux.png | Bin 26572 -> 0 bytes .../SelectInput-default--chromium-linux.png | Bin 0 -> 23183 bytes .../SelectInput-default--firefox-linux.png | Bin 0 -> 33670 bytes .../SelectInput-default--webkit-linux.png | Bin 0 -> 20302 bytes .../SelectInput-multiple--chromium-linux.png | Bin 0 -> 32818 bytes .../SelectInput-multiple--firefox-linux.png | Bin 0 -> 43927 bytes .../SelectInput-multiple--webkit-linux.png | Bin 0 -> 29983 bytes .../SelectInput-other--chromium-linux.png | Bin 0 -> 23107 bytes .../SelectInput-other--firefox-linux.png | Bin 0 -> 31148 bytes .../SelectInput-other--webkit-linux.png | Bin 0 -> 19462 bytes ...electInput-placeholder--chromium-linux.png | Bin 0 -> 29850 bytes ...SelectInput-placeholder--firefox-linux.png | Bin 0 -> 40764 bytes .../SelectInput-placeholder--webkit-linux.png | Bin 0 -> 26464 bytes ...donly-disabled-loading--chromium-linux.png | Bin 0 -> 31558 bytes ...adonly-disabled-loading--firefox-linux.png | Bin 0 -> 44501 bytes ...eadonly-disabled-loading--webkit-linux.png | Bin 0 -> 29488 bytes .../SelectInput-skeleton--chromium-linux.png | Bin 0 -> 15081 bytes .../SelectInput-skeleton--firefox-linux.png | Bin 0 -> 22870 bytes .../SelectInput-skeleton--webkit-linux.png | Bin 0 -> 12878 bytes ...SelectInput-with-value--chromium-linux.png | Bin 0 -> 29012 bytes .../SelectInput-with-value--firefox-linux.png | Bin 0 -> 40459 bytes .../SelectInput-with-value--webkit-linux.png | Bin 0 -> 26434 bytes .../components/OnyxListbox/OnyxMiniSearch.vue | 22 +-- .../OnyxSelectInput.ct.tsx} | 35 ++--- .../OnyxSelectInput.stories.ts} | 30 ++-- .../OnyxSelectInput.vue} | 144 ++++++++++-------- .../{OnyxSelect => OnyxSelectInput}/types.ts | 37 ++--- packages/sit-onyx/src/i18n/locales/de-DE.json | 3 + packages/sit-onyx/src/i18n/locales/en-US.json | 3 + packages/sit-onyx/src/index.ts | 4 +- packages/sit-onyx/src/utils/attrs.ts | 37 +++++ 54 files changed, 184 insertions(+), 154 deletions(-) create mode 100644 .changeset/eleven-sheep-fry.md delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-default--chromium-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-default--firefox-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-default--webkit-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-multiple--chromium-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-multiple--firefox-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-multiple--webkit-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-other--chromium-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-other--firefox-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-other--webkit-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-placeholder--chromium-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-placeholder--firefox-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-placeholder--webkit-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-readonly-disabled-loading--chromium-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-readonly-disabled-loading--firefox-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-readonly-disabled-loading--webkit-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-skeleton--chromium-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-skeleton--firefox-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-skeleton--webkit-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-with-value--chromium-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-with-value--firefox-linux.png delete mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelect/Select-with-value--webkit-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-default--chromium-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-default--firefox-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-default--webkit-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-multiple--chromium-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-multiple--firefox-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-multiple--webkit-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-other--chromium-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-other--firefox-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-other--webkit-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-placeholder--chromium-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-placeholder--firefox-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-placeholder--webkit-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-readonly-disabled-loading--chromium-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-readonly-disabled-loading--firefox-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-readonly-disabled-loading--webkit-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-skeleton--chromium-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-skeleton--firefox-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-skeleton--webkit-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-with-value--chromium-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-with-value--firefox-linux.png create mode 100644 packages/sit-onyx/playwright/snapshots/components/OnyxSelectInput/SelectInput-with-value--webkit-linux.png rename packages/sit-onyx/src/components/{OnyxSelect/OnyxSelect.ct.tsx => OnyxSelectInput/OnyxSelectInput.ct.tsx} (84%) rename packages/sit-onyx/src/components/{OnyxSelect/OnyxSelect.stories.ts => OnyxSelectInput/OnyxSelectInput.stories.ts} (82%) rename packages/sit-onyx/src/components/{OnyxSelect/OnyxSelect.vue => OnyxSelectInput/OnyxSelectInput.vue} (63%) rename packages/sit-onyx/src/components/{OnyxSelect => OnyxSelectInput}/types.ts (71%) create mode 100644 packages/sit-onyx/src/utils/attrs.ts diff --git a/.changeset/eleven-sheep-fry.md b/.changeset/eleven-sheep-fry.md new file mode 100644 index 0000000000..3d4d432bdc --- /dev/null +++ b/.changeset/eleven-sheep-fry.md @@ -0,0 +1,5 @@ +--- +"sit-onyx": major +--- + +Renamed OnyxSelect to OnyxSelectInput diff --git a/apps/alpha-test-app/src/views/HomeView.vue b/apps/alpha-test-app/src/views/HomeView.vue index 023bd5200c..dcd0d9e778 100644 --- a/apps/alpha-test-app/src/views/HomeView.vue +++ b/apps/alpha-test-app/src/views/HomeView.vue @@ -16,7 +16,7 @@ import { OnyxLoadingIndicator, OnyxPageLayout, OnyxRadioButtonGroup, - OnyxSelect, + OnyxSelectInput, OnyxSkeleton, OnyxSwitch, OnyxTable, @@ -45,7 +45,7 @@ const COMPONENTS = [ "OnyxListbox", "OnyxLoadingIndicator", "OnyxRadioButtonGroup", - "OnyxSelect", + "OnyxSelectInput", "OnyxSkeleton", "OnyxSwitch", "OnyxTable", @@ -225,8 +225,8 @@ timerEndDate.setHours(timerEndDate.getHours() + 2); - diff --git a/apps/playground/src/components/VersionSelect.vue b/apps/playground/src/components/VersionSelect.vue index 70877c9aef..cef20dfb7d 100644 --- a/apps/playground/src/components/VersionSelect.vue +++ b/apps/playground/src/components/VersionSelect.vue @@ -1,5 +1,5 @@