Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better explain the groups param & batch effects in the intro vignette #234

Open
kelly-sovacool opened this issue Nov 19, 2020 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good issue for first-time contributors

Comments

@kelly-sovacool
Copy link
Member

Note from lab meeting code club on the documentation:

There was confusion about how the groups parameter works and why one would want to use it. Need to explicitly state that observations (rows) from the same group are kept together in the train/test split. Overfitting was brought up as a concern -- thinking that using groups might cause models to be overfit. But really it would reveal whether overfitting has occurred.

@kelly-sovacool kelly-sovacool added the documentation Improvements or additions to documentation label Nov 19, 2020
@kelly-sovacool kelly-sovacool added the good first issue Good issue for first-time contributors label Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good issue for first-time contributors
Projects
None yet
Development

No branches or pull requests

2 participants