Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about Unified Push #87

Closed
bahur142 opened this issue Sep 18, 2021 · 1 comment
Closed

Question about Unified Push #87

bahur142 opened this issue Sep 18, 2021 · 1 comment
Labels
invalid This doesn't seem right

Comments

@bahur142
Copy link

Hello developers of Schildi Chat.
Sorry for opening ticket in your issue tracker, but I don't know where to ask a question about UP. Feel free to close it.

I've managed to do my own fork of Element Android about an year ago. Using also self-hosted push server Sygnal for delivering pushes. Last days I am reading some publications about Unified Push and looking forward on how can I use it.
Since Element still not provide UP, I am looking at your application Schildi Chat and see that you have implemented successfully UP. Since I am not a programmer and did not understand Java/Kotlin (though I have my own fork), want to ask about the following commit:
a3a946f#diff-44923f4e9b5a6e14764ee8b524a9d8afaeb48ac8f6cb8d708b0794965c557692
If I use the code of these 24 changed files at the time of commit, can I build successfully a version of my own Element with UP support? Is it enough to support UP only with this commit and the files changed?

@SpiritCroc
Copy link
Member

For building Element with unified push, easiest would be just using this PR: element-hq#3448
SchildiChat's UP implementation is also based on that PR.

@SpiritCroc SpiritCroc added the invalid This doesn't seem right label Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants