fix: remove singing requests #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #951 +/- ##
==========================================
- Coverage 57.77% 57.19% -0.58%
==========================================
Files 65 65
Lines 592 584 -8
Branches 32 29 -3
==========================================
- Hits 342 334 -8
Misses 245 245
Partials 5 5 ☔ View full report in Codecov by Sentry. |
|
Don't think we shall remove it. We just need to make sure it is optional. Otherwise, users will have a breaking change, if they assume the AWS4 signatures are still required. Could be marked as |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 3, 2024
# [7.0.0](v6.13.8...v7.0.0) (2024-04-03) ### Bug Fixes * **deps:** update dependency aws4-axios to v3.3.4 ([#1018](#1018)) ([40f547d](40f547d)) * **deps:** update dependency axios to v1.6.8 ([#1023](#1023)) ([ae0275e](ae0275e)) * installs @scaleleap/semantic-release-config ([dccfedb](dccfedb)) * remove singing requests ([#951](#951)) ([4169903](4169903)) * update @scaleleap/semantic-release-config ([03d1fe4](03d1fe4)) ### Features * update API models ([#1031](#1031)) ([3215b39](3215b39)), closes [#1021](#1021) [#1022](#1022) [#564](#564) ### BREAKING CHANGES * - Removes authorization API client. Refer to the [SP-API Deprecations](https://developer-docs.amazon.com/sp-api/docs/sp-api-deprecations) table for more information. Adds support for: - Data Kiosk APi - Fulfillment Inbound API (`v20240320`) - Shipping API (`v2`) - Supply Sources API
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting October 2, 2023, SP-API no longer requires the use of AWS Identity and Access Management (IAM) or AWS Signature Version 4, which means developers will not need to register for IAM resources or sign SP-API requests with AWS Signature Version 4.
SP-API will continue to use Login with Amazon (LWA) access tokens for each SP-API request. LWA is based on OAuth 2.0, which has been broadly adopted for user-authorized exchanges across sites.
Ref:
https://developer-docs.amazon.com/sp-api/changelog/sp-api-will-no-longer-require-aws-iam-or-aws-signature-version-4