Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] financial api has wrong name. #61

Closed
michael-land opened this issue Apr 9, 2021 · 4 comments
Closed

[Bug] financial api has wrong name. #61

michael-land opened this issue Apr 9, 2021 · 4 comments
Assignees

Comments

@michael-land
Copy link

https://github.com/ScaleLeap/selling-partner-api-sdk/blob/master/src/api-models/finances-api-model/api.ts#L2152

not sure why it mapped to DefaultApi, it should be FinancesApi

@nguyentoanit
Copy link
Contributor

@xiaoyu-tamu :
There was no official document about API class names that I could find.
But when I try to add tags in financial specification. It works great.

At the moment, we're using OpenAPI Generator to generate typescript-axios client.

Therefore, I opened the issues to add tags into specification
and confirm about using tags for API class name in generator.

Thanks.

@nguyentoanit nguyentoanit pinned this issue Apr 12, 2021
@nguyentoanit nguyentoanit unpinned this issue Apr 12, 2021
@moltar
Copy link
Contributor

moltar commented Apr 27, 2021

@nguyentoanit was this fixed today with #78 & #79?

@nguyentoanit
Copy link
Contributor

@xiaoyu-tamu:
We have created an additional layer that wraps the generated code into something more user friendly.
You can use FinancesApiClient replace for DefaultApi in v3.0.0

@nguyentoanit
Copy link
Contributor

nguyentoanit commented Apr 27, 2021

@moltar : I think this wasn't fixed completely. Because specification still mapped to DefaultApi
But users can use our additional layers as a replacement.

@moltar moltar closed this as completed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants