Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency axios to v0.27.0 #433

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 25, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
axios (source) 0.26.1 -> 0.27.0 age adoption passing confidence

Release Notes

axios/axios

v0.27.0

Compare Source

Breaking changes:

  • New toFormData helper function that allows the implementor to pass an object and allow axios to convert it to FormData (#​3757)
  • Removed functionality that removed the the Content-Type request header when passing FormData (#​3785)
  • (*) Refactored error handling implementing AxiosError as a constructor, this is a large change to error handling on the whole (#​3645)
  • Separated responsibility for FormData instantiation between transformRequest and toFormData (#​4470)
  • (*) Improved and fixed multiple issues with FormData support (#​4448)

QOL and DevX improvements:

  • Added a multipart/form-data testing playground allowing contributors to debug changes easily (#​4465)

Fixes and Functionality:

  • Refactored project file structure to avoid circular imports (#​4515) & (#​4516)
  • Bumped follow-redirects to ^1.14.9 (#​4562)

Internal and Tests:

  • Updated dev dependencies to latest version

Documentation:

  • Fixing incorrect link in changelog (#​4551)

Notes:

  • (*) Please read these pull requests before updating, these changes are very impactful and far reaching.

Configuration

📅 Schedule: "every weekday" in timezone Etc/UTC.

🚦 Automerge: Disabled due to failing status checks.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the renovatebot label Apr 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #433 (44f706d) into master (8435aad) will decrease coverage by 0.62%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   58.27%   57.65%   -0.63%     
==========================================
  Files          62       62              
  Lines         556      562       +6     
  Branches       27       30       +3     
==========================================
  Hits          324      324              
- Misses        232      238       +6     
Impacted Files Coverage Δ
src/helpers/api-client-helpers.ts 53.65% <0.00%> (-9.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8435aad...44f706d. Read the comment docs.

@nguyentoanit
Copy link
Contributor

@moltar : new Axios version was Refactored error handling implementing AxiosError as a constructor.
This changed axios error response type from any to unknown? 🤔

Therefore, I added a type guard in axios interceptor here:

axiosInstance.interceptors.response.use(
(response: AxiosResponse) => response,
(error: AxiosError) => {
if (ApiClientHelpers.isAPIModelError(error)) {
throw apiErrorFactory(error)
}
throw error
},
)
return axiosInstance
}

@nguyentoanit nguyentoanit requested a review from moltar April 26, 2022 04:48
@nguyentoanit nguyentoanit merged commit 4461da1 into master Apr 27, 2022
@nguyentoanit nguyentoanit deleted the renovate/axios-0.x branch April 27, 2022 01:30
github-actions bot pushed a commit that referenced this pull request Apr 27, 2022
## [6.2.1](v6.2.0...v6.2.1) (2022-04-27)

### Bug Fixes

* **deps:** update dependency axios to v0.27.0 ([#433](#433)) ([4461da1](4461da1))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants