Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add IN as a marketplace #422

Merged
merged 3 commits into from
Sep 7, 2021
Merged

Conversation

NishealJ
Copy link
Contributor

@NishealJ NishealJ commented Sep 7, 2021

Add IN marketplace & advertising details.

Closes #421

src/marketplaces/in.ts Show resolved Hide resolved
src/marketplaces/in.ts Show resolved Hide resolved
Copy link
Collaborator

@moltar moltar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bid values are not accurate.

src/marketplaces/in.ts Show resolved Hide resolved
@NishealJ
Copy link
Contributor Author

NishealJ commented Sep 7, 2021

@moltar done the needed changes, Also are you planning any release soon? So that I can update the @scaleleap/amazon-marketplaces version at https://github.com/ScaleLeap/amazon-advertising-api-sdk

@moltar moltar merged commit 91d9f30 into ScaleLeap:master Sep 7, 2021
@moltar
Copy link
Collaborator

moltar commented Sep 7, 2021

It will release shortly. Revonate Bot will also create a PR in amazon-advertising-api-sdk

github-actions bot pushed a commit that referenced this pull request Sep 7, 2021
# [12.0.0](v11.1.0...v12.0.0) (2021-09-07)

### Bug Fixes

* adds advertising to India marketplace ([#422](#422)) ([91d9f30](91d9f30))

### BREAKING CHANGES

* adds advertising to India marketplace
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

🎉 This PR is included in version 12.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marketplace A21TJRUUN4KGV does not have advertising
2 participants