Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update campaign types edge case no strategy #789

Merged

Conversation

mayan-jbsmith
Copy link
Contributor

Found an edge case in campaigns returned without a strategy in the bidding element.

added test for where campaign response has no bidding strategy by making it optional
updating the type spec for campaign where the bidding strategy is not returned
@moltar moltar merged commit 076869f into ScaleLeap:master Jun 22, 2021
@moltar
Copy link
Contributor

moltar commented Jun 22, 2021

Thank you. Should release shortly.

github-actions bot pushed a commit that referenced this pull request Jun 22, 2021
## [3.1.18](v3.1.17...v3.1.18) (2021-06-22)

### Bug Fixes

* updates campaign types edge case no strategy ([#789](#789)) ([076869f](076869f))
@github-actions
Copy link

🎉 This PR is included in version 3.1.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants