-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(Thumbnail): Thumb without external libraries #499
Conversation
Is there any reason not to use |
The image crate looks a lot more mature. 3700 stars on Github vs 5 for thumbnailer. Also, please make the Cargo workflow pass. |
When you say media, is images and video files? |
That is correct. Looking at the dependency used, it looks like they also use |
For video files, I didn't find any other solution without using ffmpeg, so I will back ffmpeg lib for it thumbnailer, inside crate, is using ffmpeg lib as well to make thumb from videos |
Hello my friend, so far on MacOS preview opened to a black screen MacOS Screen_Recording_2023-03-24_at_3.29.08_PM.movWindows- Recording.2023-03-24.153137.mp4 |
…mb-without-command
…mb-without-command
…mb-without-command
So I pulled latest changes and error was gone, but I did have @InfamousVague and @WanderingHogan both test with me and neither of us could get the thumbnail to appear with PDF or MOV (verified we have ffmeg installed |
With the release coming up we are going to close this, and come back to it after we make the public builds. |
What this PR does 📖
1. Updated the code, to just use crates and not necessary more external libraries to upload thumbnails for pdf files
a. External libraries can let app with bigger size and can affect performance
b. Video thumbs will keep ffmpeg lib for now
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤