feat(glyphs): recently used glyphs functionality AP-341 #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
Jekrimo
approved these changes
Dec 23, 2021
|
AP-314, AP-318, AP-264 - fixed ✅ |
stavares843
approved these changes
Dec 23, 2021
stavares843
added
the
QA tested
|
do you want to add this one as well? 😂 AP-359 |
github-actions
bot
added
the
missing fixing conflict
| @@ -92,7 +92,7 @@ export default Vue.extend({ | |||
| requestWidth = '300' | |||
| } | |||
| const facebookOutSource = `https://www.facebook.com/plugins/video.php?href=${encodeURIComponent( | |||
| link.split('?')[0] | |||
| link.split('?')[0], | |||
There was a problem hiding this comment.
weird place to put a comma
There was a problem hiding this comment.
yeah, bad prettier
components/ui/Chat/Embeds/EmbeddedLinkContent/EmbeddedLinkContent.vue
Outdated
Show resolved
Hide resolved
components/ui/Chat/Embeds/EmbeddedLinkContent/EmbeddedLinkContent.vue
Outdated
Show resolved
Hide resolved
WanderingHogan
suggested changes
Dec 24, 2021
WanderingHogan
added
Changes Requested
* add padding to bottom of enhancers glyph list to show all * add small img to reply rather than string of glyph url
* added state for recently used glyphs with a counter * removed global style hidiing typographyText on xs devices * mobile styles for recently selected glyphs
josephmcg
removed
Changes Requested
lol I'll do that one separately since this is already tackling a bunch of issues. I think it was introduced with the swiper stuff |
|
neat! 🎉 |
stavares843
added
the
Missing Dev Review
|
just added the missing dev review label because of @WanderingHogan review |
WanderingHogan
approved these changes
Dec 27, 2021
WanderingHogan
removed
the
Missing Dev Review
github-actions
bot
removed
the
QA tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
AP-341
AP-318
AP-264
Which issue(s) this PR fixes 🔨
AP-314, AP-318, AP-264
Special notes for reviewers 🗒️
Additional comments 🎤