Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iOS): iOS Cleanup & LESS rewrite #693

Merged
merged 16 commits into from
Dec 19, 2021
Merged

feat(iOS): iOS Cleanup & LESS rewrite #693

merged 16 commits into from
Dec 19, 2021

Conversation

InfamousVague
Copy link

What this PR does 📖
This PR cleans up a ton of less code as well as fixes a bunch of visual bugs with the iOS PWA.

@stavares843
Copy link
Member

checking 🔨

@stavares843
Copy link
Member

stavares843 commented Dec 18, 2021 •
edited
Loading

Captura de ecrã 2021-12-18, às 21 15 02

create account view

dev vs this branch

iPhone 13 Pro Max simulator

  • missing padding on the buttons
  • content is not vertically centered

@stavares843 stavares843 added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Dec 18, 2021
@stavares843
Copy link
Member

stavares843 commented Dec 19, 2021 •
edited
Loading

selecting an option on the marketplace appears like this

Captura de ecrã 2021-12-19, às 02 45 57

vs dev

Captura de ecrã 2021-12-19, às 02 46 51

Chrome, macOS

@stavares843
Copy link
Member

stavares843 commented Dec 19, 2021 •
edited
Loading

colors are missing when going to the wallet

Captura de ecrã 2021-12-19, às 02 52 26

vs dev

Captura de ecrã 2021-12-19, às 02 52 33

Chrome, macOS

@stavares843
Copy link
Member

stavares843 commented Dec 19, 2021 •
edited
Loading

missing colors on settings > realms

is missing the red/green copy where it says true/false

Captura de ecrã 2021-12-19, às 02 55 42

vs dev

Captura de ecrã 2021-12-19, às 02 55 47

Chrome, macOS

@stavares843
Copy link
Member

stavares843 commented Dec 19, 2021 •
edited
Loading

going to files shows the bar green instead of blue, not sure if is a change in purpose

Captura de ecrã 2021-12-19, às 02 57 36

vs dev

Captura de ecrã 2021-12-19, às 02 57 40

Chrome, macOS

stavares843
stavares843 requested changes Dec 19, 2021
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a couple comments 🔨

@stavares843 stavares843 added the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Dec 19, 2021
@InfamousVague
Copy link
Author

selecting an option on the marketplace appears like this

Captura de ecrã 2021-12-19, às 02 45 57

vs dev

Captura de ecrã 2021-12-19, às 02 46 51

Chrome, macOS

I'm going to redo this sidebar anyways, let's not worry about this one. It doesn't fit the sidebar style of the rest of our app.

@InfamousVague
Copy link
Author

I think I've fixed the rest. please ignore the center align issues on the mobile signup. I did this intentionally so that your thumbs have to reach less far to use the app.

@stavares843 stavares843 removed the Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. label Dec 19, 2021
WanderingHogan
WanderingHogan approved these changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@WanderingHogan WanderingHogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments dm'ed

@stavares843
Copy link
Member

create a server

this branch
Captura de ecrã 2021-12-19, às 22 48 37

vs dev

Captura de ecrã 2021-12-19, às 22 48 26

iPhone 6/7/8 Plus

@stavares843
Copy link
Member

going to chat > glyphs/emojis

Captura de ecrã 2021-12-19, às 22 52 42

vs dev

Captura de ecrã 2021-12-19, às 22 52 48

iPhone 6/7/8 Plus

stavares843
stavares843 requested changes Dec 19, 2021
View reviewed changes
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty neat! 🎉

@stavares843 stavares843 added QA tested One QA Person has tested - Needs QA Lead review still and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Dec 19, 2021
@stavares843 stavares843 changed the title iOS Cleanup & LESS rewrite feat(iOS): iOS Cleanup & LESS rewrite Dec 19, 2021
@stavares843 stavares843 merged commit 49e2130 into dev Dec 19, 2021
@stavares843 stavares843 deleted the iOS branch December 19, 2021 23:07
@github-actions github-actions bot removed the QA tested One QA Person has tested - Needs QA Lead review still label Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavares843 stavares843 stavares843 approved these changes

@WanderingHogan WanderingHogan WanderingHogan approved these changes

@josephmcg josephmcg Awaiting requested review from josephmcg

@phillsatellite phillsatellite Awaiting requested review from phillsatellite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InfamousVague @stavares843 @WanderingHogan