Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(indexedDB): remove dexie package and add polyfill for firefox #5036

Merged

Conversation

josephmcg
Copy link
Contributor

What this PR does 📖

  • remove dexie package, use native api to get list of databases instead
    • not supported in firefox, added polyfill to get around it

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@josephmcg josephmcg linked an issue Sep 27, 2022 that may be closed by this pull request
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 27, 2022
@josephmcg josephmcg force-pushed the 5035-remove-dexie-package-and-use-native-indexeddb-api branch from 28821af to 180df26 Compare September 27, 2022 07:59
Copy link
Contributor

@nathan-power nathan-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Alright For Me

@josephmcg josephmcg merged commit 8f27701 into dev Sep 27, 2022
@josephmcg josephmcg deleted the 5035-remove-dexie-package-and-use-native-indexeddb-api branch September 27, 2022 08:08
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove dexie package and use native indexeddb api
2 participants