chore(remove): cleanup of old files #4987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
|
@iltumio can you please check if there are any Solana config we can remove and any functions in the SolanaManager we dont use anymore (like the requestAirdrop)? Thanks! |
stavares843
added
the
draft
molimauro
changed the title
molimauro
removed
the
draft
aewing
approved these changes
Sep 23, 2022
github-actions
bot
added
the
missing fixing conflict
stavares843
removed
the
missing fixing conflict
aewing
removed
the
Missing Dev Review
iltumio
approved these changes
Sep 23, 2022
github-actions
bot
added
the
missing fixing conflict
|
Why this is blocked @stavares843? |
|
yeah this would be good to get in soon so we don't get more conflicts |
molimauro
force-pushed
the
solana-cleanup
branch
from
260a9c7 to
001c310
Compare
github-actions
bot
removed
the
missing fixing conflict
|
this fleek
vs dev
something broke with the modal 🔨 |
|
Sorry @stavares843 i dont have that issue locally 😅 |
|
Its not related to this, seems a problem with the nodes config on Fleek |
|
will test locally instead 😅 thanks for taking a look |
|
Gonna merge this! |
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤