Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(button): show password toggle #4960

Merged
merged 2 commits into from
Sep 21, 2022
Merged

feat(button): show password toggle #4960

merged 2 commits into from
Sep 21, 2022

Conversation

jasonwoodland
Copy link
Contributor

What this PR does 📖

  • Add show password toggle to InteractablesInput
  • Fix placeholder color
  • Fix border radius when input has a button

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@jasonwoodland jasonwoodland marked this pull request as ready for review September 21, 2022 04:07
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 21, 2022
nathan-power
nathan-power suggested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@nathan-power nathan-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one change required

components/interactables/Input/Input.html Show resolved Hide resolved
nathan-power
nathan-power approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@nathan-power nathan-power left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathan-power nathan-power merged commit aa9bd42 into dev Sep 21, 2022
@nathan-power nathan-power deleted the 4389-ap-2207-unhide-password-field-toggle branch September 21, 2022 06:46
@github-actions github-actions bot removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-power nathan-power nathan-power approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AP-2207: unhide password field toggle
2 participants
@jasonwoodland @nathan-power