Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): changelog modal style #4900

Closed
wants to merge 1 commit into from
Closed

fix(modal): changelog modal style #4900

wants to merge 1 commit into from

Conversation

molimauro
Copy link
Contributor

What this PR does πŸ“–

  • Fix the style for the changelog modal

Which issue(s) this PR fixes πŸ”¨

  • Resolve #

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 16, 2022
@stavares843
Copy link
Member

Captura de ecrã 2022-09-19, às 17 05 36

Captura de ecrã 2022-09-19, às 17 05 46

if the browser is a little bit smaller, the got it button is hidden and there's no scroll

not against merging, way better compared with prod

@stavares843 stavares843 added the QA tested One QA Person has tested - Needs QA Lead review still label Sep 19, 2022
@molimauro
Copy link
Contributor Author

Nah i'll fix that thanks :)

@molimauro molimauro added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed QA tested One QA Person has tested - Needs QA Lead review still Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Sep 19, 2022
@github-actions github-actions bot added the missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa label Sep 20, 2022
@josephmcg
Copy link
Contributor

josephmcg commented Sep 20, 2022 •
edited
Loading

Nathan fixed this issue and consolidated some of the basic modals here.

We should try to work on specific github issues so we don't step on each other's toes

@josephmcg josephmcg closed this Sep 20, 2022
@molimauro
Copy link
Contributor Author

Sorry @josephmcg i know, it was on Friday and i tried to put a patch for the early access

@molimauro
Copy link
Contributor Author

But dope, the modals needed a refactor ;)

@stavares843 stavares843 deleted the fix_changelog_modal_style branch September 21, 2022 20:32
@stavares843
Copy link
Member

Captura de ecrã 2022-09-21, às 21 34 39

nathan's fix is also cool, can we update the icon instead of the ''x'' there? @josephmcg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavares843 stavares843 stavares843 approved these changes

Assignees
No one assigned
Labels
Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. missing fixing conflict Conflict needs to be handled, then re-tested by devs/qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@molimauro @stavares843 @josephmcg