Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): add typing indicator in groups and dms #4789

Merged
merged 1 commit into from
Sep 15, 2022
Merged

feat(chat): add typing indicator in groups and dms #4789

merged 1 commit into from
Sep 15, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Sep 14, 2022 •
edited
Loading

What this PR does 📖

  • typing indicator (text) for dms and groups beneath chatbar
  • adjust margin/padding of desktop chat page to better accommodate new group chat sidebar component
  • better styles for group sidebar
  • switch toolbar call icon color to gray all the time for groups. It was previously only checking for connected peers in the conversation

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@josephmcg josephmcg linked an issue Sep 14, 2022 that may be closed by this pull request
chat - add typing footer below the input #4771
Closed
@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Sep 14, 2022
@phillsatellite
Copy link
Contributor

Note about a few things I found:

  1. On Safari the 3 dots sits on top of where the indicator is
Screen.Recording.2022-09-14.at.2.12.21.PM.mov
  1. Kinda similar to bug Joe already found, if users are not friends in the group they will not appear online

Screen Shot 2022-09-14 at 2 14 38 PM

Screen Shot 2022-09-14 at 2 14 06 PM

Otherwise worked well! 🔥

@phillsatellite phillsatellite added the QA tested One QA Person has tested - Needs QA Lead review still label Sep 14, 2022
@josephmcg josephmcg force-pushed the 4771-chat-add-typing-footer-below-the-input branch from ec116d7 to 1928a19 Compare September 14, 2022 22:20
@josephmcg
Copy link
Contributor Author

Seems like Mauro and Thomas fixed the safari bug. I rebased so it should work better now on this branch

@josephmcg josephmcg merged commit 37816bf into dev Sep 15, 2022
@josephmcg josephmcg deleted the 4771-chat-add-typing-footer-below-the-input branch September 15, 2022 01:49
@github-actions github-actions bot removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA QA tested One QA Person has tested - Needs QA Lead review still labels Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonwoodland jasonwoodland jasonwoodland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chat - add typing footer below the input
3 participants
@josephmcg @phillsatellite @jasonwoodland