feat(jest): 100% coverage for utilities/chat #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
stavares843
approved these changes
Aug 26, 2022
josephmcg
approved these changes
Aug 29, 2022
github-actions
bot
removed
the
Missing Dev Review
|
@josephmcg let us know what we should address there and we can address your comments on a new PR considering this one was already merged 🔨 |
|
oh im sorry, I was totally reading it incorrectly (monday morning brain). this works fine 100% my bad
|
|
would avoid casting as 'any' as a rule of thumb, especially if we know the type (boolean in this case) |
|
😂 thanks @josephmcg 🔨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Increase coverage for two untested cases.
Which issue(s) this PR fixes 🔨
AP-2247
Special notes for reviewers 🗒️
Additional comments 🎤