Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calls): add fullscreen support #4439

Merged
merged 2 commits into from
Aug 24, 2022
Merged

feat(calls): add fullscreen support #4439

merged 2 commits into from
Aug 24, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Aug 24, 2022

What this PR does 📖

  • uses fullscreen api
  • if the user wants to enlarge call window but keep other parts of the app visible, they can use the dragbar

Which issue(s) this PR fixes 🔨
AP-2193

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Aug 24, 2022
Copy link
Contributor

@molimauro molimauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dope!

@molimauro molimauro added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Aug 24, 2022
@stavares843 stavares843 added ready to merge and removed Ready for QA Ready for QA team to test, Devs approved. labels Aug 24, 2022
@josephmcg josephmcg merged commit cbdb31b into dev Aug 24, 2022
@josephmcg josephmcg deleted the AP2193 branch August 24, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants