Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat): display uploaded files in ui #4046

Merged
merged 3 commits into from
Jul 26, 2022
Merged

feat(chat): display uploaded files in ui #4046

merged 3 commits into from
Jul 26, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Jul 25, 2022

What this PR does 📖

  • display uploaded files in conversation (kept in chat vuex store tied to conversation id)
  • drag and drop functionality for chat and personal files uploads
    • hook up consent scan check to iridium settings manager and created action to simplify that logic
  • paste file functionality for chat file uploads
  • refactor chatbar css
    • there was a missing class container, so links weren't getting properly styled.
    • I removed a lot of unnecessary css and switched that whole area to flex

Which issue(s) this PR fixes 🔨
AP-2008, AP-2012

Special notes for reviewers 🗒️

  • files will not send, that will be separate functionality

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jul 25, 2022
@molimauro
Copy link
Contributor

image

One little thing on the chatbar, should be 48px height given the 16px font.

Also if you notice:
image

when you go on a new line the cursor is a little too close to the bottom border:
image

@molimauro molimauro added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jul 25, 2022
@josephmcg
Copy link
Contributor Author

@molimauro i thought this was consistent with the current dev branch. i'll take another look tomorrow

@josephmcg
Copy link
Contributor Author

josephmcg commented Jul 25, 2022

this appears to be consistent with dev branch.

The scope of this is already quite large, so I think we should improve chatbar styles later

top 2 -dev
bottom 2 -this branch

image

image

image

image

@josephmcg josephmcg merged commit 8359643 into iridium-dev Jul 26, 2022
@josephmcg josephmcg deleted the AP2008 branch July 26, 2022 00:43
@github-actions github-actions bot removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. iridium-dev labels Jul 26, 2022
@molimauro
Copy link
Contributor

Strange, the cursor appears different on my screen from dev and this, also the height. In any case no problem, we can track this and come back later, thanks for checking ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants