feat(settings-profile): account link component/markup #3953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavares843
added
Missing Dev Review
…s to global sheet
josephmcg
force-pushed
the
AP-1957
branch
2 times, most recently
from
8db8639 to
81c19c0
Compare
github-actions
bot
removed
the
Missing Dev Review
JustZacca
pushed a commit
that referenced
this pull request
Jul 13, 2022
* feat(settings-profile): account link component/markup * fix(settings-profile): tweak spacing for main section in profile settings * refactor(profile): create transition .less function and move keyframes to global sheet * refactor(accounts): remove html wrappers and simplify css, move component files * fix(profile): v bind typo fix * fix(profile): typo * fix(profile): show controls on mobile and remove spacer Co-authored-by: Joe McGrath <[email protected]>
nathan-power
added a commit
that referenced
this pull request
Jul 14, 2022
* feat(settings-profile): account link component/markup * fix(settings-profile): tweak spacing for main section in profile settings * refactor(profile): create transition .less function and move keyframes to global sheet * refactor(accounts): remove html wrappers and simplify css, move component files * fix(profile): v bind typo fix * fix(profile): typo * fix(profile): show controls on mobile and remove spacer Co-authored-by: Joe McGrath <[email protected]>
JustZacca
pushed a commit
that referenced
this pull request
Jul 15, 2022
* feat(settings-profile): account link component/markup * fix(settings-profile): tweak spacing for main section in profile settings * refactor(profile): create transition .less function and move keyframes to global sheet * refactor(accounts): remove html wrappers and simplify css, move component files * fix(profile): v bind typo fix * fix(profile): typo * fix(profile): show controls on mobile and remove spacer Co-authored-by: Joe McGrath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Add the markup for the accounts list in the profile settings page.
Which issue(s) this PR fixes 🔨
AP-1957
https://satellite-im.atlassian.net/browse/AP-1957
Special notes for reviewers 🗒️
As current design in Figma had a few layout restraints, the design was tweaked after discussion with Joe so that it is now easier to access all elements of the original design on all devices.
Additional comments 🎤