feat(iridium): add settings manager #3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonwoodland
added
the
draft
github-actions
bot
added
the
Missing Dev Review
stavares843
added
iridium
and removed
Missing Dev Review
molimauro
reviewed
Jul 11, 2022
molimauro
suggested changes
Jul 11, 2022
jasonwoodland
removed
the
draft
stavares843
added
the
Missing Dev Review
josephmcg
approved these changes
Jul 14, 2022
molimauro
approved these changes
Jul 14, 2022
molimauro
removed
the
Missing Dev Review
JustZacca
pushed a commit
that referenced
this pull request
Jul 14, 2022
* feat(iridium): add settings manager * refactor(iridium): instantiate managers in constructor * feat(iridium): add settings to iridium manager * feat(settings): use iridium settings manager * feat(theme): use iridium theme settings * chore(store): remove old theme types/definitions * feat(iridium): add init method for profile/group managers * feat(theme): generate rgb color values for selection * feat(settings): move flip local video setting to iridium * chore(build): add deepmerge package * feat(merge): add deepmerge utility function * feat(settings): deep merge initial state * feat(settings/audio): add notification sounds to settings * feat(iridium): add keybinds to settings * feat(settings): connect keybinds to iridium * style(settings): use record for object types * feat(iridium): add privacy to settings * feat(settings): connect privacy to iridium * refactor(settings): iterate over enum to generate initial state * fix(build): bump @nuxtjs/eslint-config-typescript version * style: organise imports * fix(settings): only set in iridium if the value was changed * fix(settings/audio): default values keys
JustZacca
pushed a commit
that referenced
this pull request
Jul 15, 2022
* feat(iridium): add settings manager * refactor(iridium): instantiate managers in constructor * feat(iridium): add settings to iridium manager * feat(settings): use iridium settings manager * feat(theme): use iridium theme settings * chore(store): remove old theme types/definitions * feat(iridium): add init method for profile/group managers * feat(theme): generate rgb color values for selection * feat(settings): move flip local video setting to iridium * chore(build): add deepmerge package * feat(merge): add deepmerge utility function * feat(settings): deep merge initial state * feat(settings/audio): add notification sounds to settings * feat(iridium): add keybinds to settings * feat(settings): connect keybinds to iridium * style(settings): use record for object types * feat(iridium): add privacy to settings * feat(settings): connect privacy to iridium * refactor(settings): iterate over enum to generate initial state * fix(build): bump @nuxtjs/eslint-config-typescript version * style: organise imports * fix(settings): only set in iridium if the value was changed * fix(settings/audio): default values keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
Which issue(s) this PR fixes 🔨
AP-1952
Special notes for reviewers 🗒️
Additional comments 🎤