Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(groups): members order sorted alpha #3460

Merged
merged 1 commit into from
Jun 6, 2022
Merged

fix(groups): members order sorted alpha #3460

merged 1 commit into from
Jun 6, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Jun 3, 2022

What this PR does 📖

  • set group members with an alpha sort. it seems like the backend returns them in a random order every time
  • improve performance w/ find rather than iterating 100% of the time. a couple other mutations here could use this same treatment

Which issue(s) this PR fixes 🔨
AP-1698

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Jun 3, 2022
@netlify
Copy link

netlify bot commented Jun 3, 2022

Yeeeehaw, deploy preview is ready!

Name Link
🔨 Latest commit 8988f95
🔍 Latest deploy log https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/629a46f1893537000836e1f9
😎 Deploy Preview https://deploy-preview-3460--adoring-edison-dbcef8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@molimauro molimauro added Ready for QA Ready for QA team to test, Devs approved. and removed Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA labels Jun 3, 2022
Copy link
Member

@stavares843 stavares843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captura de ecrã 2022-06-03, às 16 53 17

fixed

Captura de ecrã 2022-06-03, às 16 49 37

but the order is not the same then the one that we have on friends list

@stavares843 stavares843 added Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. and removed Ready for QA Ready for QA team to test, Devs approved. labels Jun 3, 2022
@phillsatellite
Copy link
Contributor

One little thing I wanted to ask was when you are adding users in the new group chat modal should they be listed alphabetical or add as user selected?
Screen Shot 2022-06-03 at 12 05 24 PM

@josephmcg
Copy link
Contributor Author

These changes do not affect the quick chat popup. That pulls from the 'friends' store namespace. this sets the 'groups' namespace list to alphabetical order so the group chat icons/names don't change order every time you click on a group

@josephmcg josephmcg added Ready for QA Ready for QA team to test, Devs approved. and removed Changes Requested Changes have been requested by Dev or QA, once the changes have been made, remove this label. labels Jun 6, 2022
@stavares843 stavares843 merged commit 9a1c3cf into dev Jun 6, 2022
@stavares843 stavares843 deleted the AP1698 branch June 6, 2022 02:25
@github-actions github-actions bot removed the Ready for QA Ready for QA team to test, Devs approved. label Jun 6, 2022
@stavares843
Copy link
Member

thanks for clarifying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants