Sa 323 - Error Modal Component #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy request for adoring-edison-dbcef8 pending review. 🔨 Explore the source changes: fd90602 |
…ut to allow different times, default set to 5 seconds, may want to go with default being no timeout in the future.
WanderingHogan
approved these changes
Nov 15, 2021
InfamousVague
approved these changes
Nov 16, 2021
Jekrimo
added a commit
to Jekrimo/Satellite-Absolute
that referenced
this pull request
Nov 16, 2021
* add error component * update translate file, add close to error modal * Move over Error component from Legacy app. Update translate files. Add timout prop to error * fix close method in modal, switched to using a prop for setCloseTimeout to allow different times, default set to 5 seconds, may want to go with default being no timeout in the future. * set global vue to 5000 * Update package.json Co-authored-by: Matt Wisniewski <[email protected]>
InfamousVague
pushed a commit
that referenced
this pull request
Dec 5, 2021
* add error component * update translate file, add close to error modal * Move over Error component from Legacy app. Update translate files. Add timout prop to error * fix close method in modal, switched to using a prop for setCloseTimeout to allow different times, default set to 5 seconds, may want to go with default being no timeout in the future. * set global vue to 5000 * Update package.json Co-authored-by: Matt Wisniewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move over Error component from Legacy app. Update translate files. Add timeout prop to error