Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest): improve naming on TextileFileSystem.test.ts #2403

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

drepram
Copy link
Contributor

@drepram drepram commented Mar 18, 2022

What this PR does πŸ“–

Improve the naming system

Which issue(s) this PR fixes πŸ”¨

AP-1087

Special notes for reviewers πŸ—’οΈ

Additional comments 🎀

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 18, 2022
@netlify
Copy link

netlify bot commented Mar 18, 2022

βœ”οΈ Yeeeehaw, deploy preview is ready!

πŸ”¨ Explore the source changes: 4bda2a5

πŸ” Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/62344c84ff16b80008a2b429

😎 Browse the preview: https://deploy-preview-2403--adoring-edison-dbcef8.netlify.app

@drepram
Copy link
Contributor Author

drepram commented Mar 18, 2022

Hi, in other news. I improved the unit test massively!

image

Once this PR gets merged, I'll add this in a new branch; or should I add it here?

@phillsatellite phillsatellite added the QA tested One QA Person has tested - Needs QA Lead review still label Mar 18, 2022
@WanderingHogan WanderingHogan removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 18, 2022
@stavares843 stavares843 changed the title feat(jest): improve naming for tests on TextileFileSystem.test.ts feat(jest): improve naming on TextileFileSystem.test.ts Mar 18, 2022
@stavares843 stavares843 merged commit ff10331 into dev Mar 18, 2022
@stavares843 stavares843 deleted the drepram/improve-naming-textilefilesystem-jest branch March 18, 2022 16:45
@github-actions github-actions bot removed the QA tested One QA Person has tested - Needs QA Lead review still label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants