feat(jest): 100% coverage for Directory.ts #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Missing Dev Review
|
βοΈ Yeeeehaw, deploy preview is ready! π¨ Explore the source changes: a02944b π Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/622f0c8e4bb06e00085df9e6 π Browse the preview: https://deploy-preview-2314--adoring-edison-dbcef8.netlify.app |
josephmcg
approved these changes
Mar 14, 2022
stavares843
requested changes
Mar 14, 2022
stavares843
added
Changes Requested
|
@stavares843 I'm not encountering that issue, about 3 seconds total. Could we get a third opinion? |
|
All seems alright? |
josephmcg
added
Ready for QA
stavares843
added
Changes Requested
|
the issue is always reproducible on my side please don't change labels if there are no new commits |
|
the CI is not having that issue but locally on my side takes those extra seconds, and on dev doesn't happen |
stavares843
approved these changes
Mar 15, 2022
|
strange, is no longer getting slow i will let you know if happens again |
github-actions
bot
removed
the
Changes Requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does π
Self-explanatory; this is an increase.
Which issue(s) this PR fixes π¨
Using the
AP-549ticket again :)Special notes for reviewers ποΈ
Additional comments π€