Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(files): Improve UX for files list view #2261

Merged
merged 6 commits into from
Mar 10, 2022
Merged

feat(files): Improve UX for files list view #2261

merged 6 commits into from
Mar 10, 2022

Conversation

josephmcg
Copy link
Contributor

@josephmcg josephmcg commented Mar 9, 2022

What this PR does 📖

  • fix overflow scroll issue
  • create separate Row component
  • set click event to the entire row
  • context menu on row rclick or kebab menu click. options are still todo. I made a ticket for it

Which issue(s) this PR fixes 🔨
AP-898

Special notes for reviewers 🗒️

  • responsive fixes are in other tickets

Additional comments 🎤

@github-actions github-actions bot added the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 9, 2022
@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Yeeeehaw, deploy preview is ready!

🔨 Explore the source changes: bf04a16

🔍 Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/622855726a69480008dbae68

😎 Browse the preview: https://deploy-preview-2261--adoring-edison-dbcef8.netlify.app

@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Yeeeehaw, deploy preview is ready!

🔨 Explore the source changes: 69a759f

🔍 Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/62285d96f56acf0008056419

😎 Browse the preview: https://deploy-preview-2261--adoring-edison-dbcef8.netlify.app

@molimauro molimauro added the Ready for QA Ready for QA team to test, Devs approved. label Mar 9, 2022
@stavares843 stavares843 removed the Missing Dev Review A Dev and a Dev Approver need to review the PR, then mark as Ready for QA label Mar 9, 2022
@phillsatellite
Copy link
Contributor

Tested: on mobile and iOS the new file button stretches across the screen, is that intended?
Simulator Screen Shot - iPhone 12 Pro - 2022-03-09 at 10 43 14

@phillsatellite phillsatellite added temporary blocked checking something QA Lead is checking something. and removed Ready for QA Ready for QA team to test, Devs approved. labels Mar 9, 2022
@josephmcg
Copy link
Contributor Author

yes, I didn't update the top 'controls' area at all

@josephmcg josephmcg added Ready for QA Ready for QA team to test, Devs approved. and removed temporary blocked checking something QA Lead is checking something. labels Mar 10, 2022
@phillsatellite phillsatellite added QA tested One QA Person has tested - Needs QA Lead review still and removed Ready for QA Ready for QA team to test, Devs approved. labels Mar 10, 2022
@josephmcg
Copy link
Contributor Author

I should mention that I removed the encrypted column in list view. it seems unnecessary while every file will be encrypted in the new update. I'd like to add a more low-key indicator if a file is shared/unencrypted. A whole column takes a lot of real estate

@stavares843 stavares843 added the temporary blocked checking something QA Lead is checking something. label Mar 10, 2022
@stavares843 stavares843 merged commit 29575f8 into dev Mar 10, 2022
@stavares843 stavares843 deleted the AP898 branch March 10, 2022 14:36
@github-actions github-actions bot removed QA tested One QA Person has tested - Needs QA Lead review still temporary blocked checking something QA Lead is checking something. labels Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants