feat(footer): connected indicator added under chatbar (AP-356)

[jpanay]

What this PR does 📖
Shows if peer is connected or disconnected under chatbar
Which issue(s) this PR fixes 🔨
AP-356

Special notes for reviewers 🗒️

Additional comments 🎤

[phillsatellite]

Should indicator appear if user has no friends added?

[jpanay]

No it should not I'll fix that

…

On Fri, Feb 4, 2022 at 2:28 PM Phill Wisniewski ***@***.***> wrote: Should indicator appear if user has no friends added? [image: Screen Shot 2022-02-04 at 2 26 59 PM] <https://user-images.githubusercontent.com/93608357/152591082-305d466c-d81f-43ba-af78-d71dbdb622bb.png> — Reply to this email directly, view it on GitHub <#1330 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQYRRHM3ZFHVU4C4XSXKP5DUZQSHPANCNFSM5NQYAQLQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[WanderingHogan]

Can you:

1. Split footer into a template, less, and vue file
2. Create a is-connected component
3. Add english to locales (in this repo, not the standalone repo)

[WanderingHogan]

/rebase

[stavares843]

Gravacao.do.ecra.2022-02-08.as.18.56.30.mov

says hogan is not connected on hogan's chat
change chat
still says hogan is not connected until page fully loads

[stavares843]

Gravacao.do.ecra.2022-02-08.as.19.03.52.mov

the connected/not connected updates fine

I closed the tab of user B and updated user A saying it was no longer connected

but then returned error on user A

and after reloading the page says user B is connected again

but the tab of user B was closed and not reopened

[netlify]

✔️ Yeeeehaw, deploy preview is ready!

🔨 Explore the source changes: 6d0362d

🔍 Inspect the deploy log: https://app.netlify.com/sites/adoring-edison-dbcef8/deploys/620821253aa16d0007edb28a

😎 Browse the preview: https://deploy-preview-1330--adoring-edison-dbcef8.netlify.app

[jpanay]

Gravacao.do.ecra.2022-02-08.as.19.03.52.mov
the connected/not connected updates fine

I closed the tab of user B and updated user A saying it was no longer connected

but then returned error on user A

and after reloading the page says user B is connected again

but the tab of user B was closed and not reopened

I'm trying to replicate this but I'm not getting that peer not connected error. I'm opening both tabs, waiting for connection, and closing one, but can't seem to get it to throw that error.

[jpanay]

Gravacao.do.ecra.2022-02-08.as.19.03.52.mov
the connected/not connected updates fine
I closed the tab of user B and updated user A saying it was no longer connected
but then returned error on user A
and after reloading the page says user B is connected again

but the tab of user B was closed and not reopened

I'm trying to replicate this but I'm not getting that peer not connected error. I'm opening both tabs, waiting for connection, and closing one, but can't seem to get it to throw that error.

Maybe I fixed it inadvertently with a few changes I made, can you test it again

[phillsatellite]

I tested again, I got same error as @stavares843 after attempting to message user B after they disconnected, the only thing that was different on mine was when I reloaded page it still said User B was not connected

[jpanay]

I tested again, I got same error as @stavares843 after attempting to message user B after they disconnected, the only thing that was different on mine was when I reloaded page it still said User B was not connected

3 machines, 3 different results, ain't I lucky gal 😂

[jpanay]

I tested again, I got same error as @stavares843 after attempting to message user B after they disconnected, the only thing that was different on mine was when I reloaded page it still said User B was not connected

Did you pull down the changes I made?

[phillsatellite]

Member

I did 🔨

[WanderingHogan]

@jpanay The error is here:

typingNotifyHandler in the chatbar.vue file.

const activePeer = this.$WebRTC.getPeer(activeFriend.address) can come back as undefined

In lieue of digging into getPeer in the webrtc library, for now, please:

In the chatbar.vue file wrap the getPeer call in a try catch,

[WanderingHogan]

@jpanay I can reproduce the error on my end

[jpanay]

@jpanay I can reproduce the error on my end

Yea I really don't know why I wasn't able to if all three of you can

[WanderingHogan]

looks good

[stavares843]

i have 2 users, they were both connected, I deactivated internet, and even now both have internet, still says one of them is not connected

full flow was

• user A added user B
• user B sent message to user A
• user A sent message to user B
• go to console network settings on user A and select offline

• user B sent message to user A - it sends
• user A sent message to user B - doesn't send, there's no internet on that user
• remove offline setting
• user A sent message to user B - sends successfully
• still shows user B not connected on user A side

[stavares843]

/rebase

[jpanay]

i have 2 users, they were both connected, I deactivated internet, and even now both have internet, still says one of them is not connected

full flow was

• user A added user B
• user B sent message to user A
• user A sent message to user B
• go to console network settings on user A and select offline

• user B sent message to user A - it sends
• user A sent message to user B - doesn't send, there's no internet on that user
• remove offline setting
• user A sent message to user B - sends successfully
• still shows user B not connected on user A side

Could you make a separate ticket for this, it's a webrtc issue beyond the scope of this PR

[stavares843]

the ticket which this tickets is expected to implement says the following:

''Show an indication under the chat input if the peer is connected/disconnected, might require checking/watching for events that don't exist?''

so, one of those events, would be a disconnected event as well, such as without internet

is not outside the scope, because the PR should include that doesn't matter if is or not a webrtc issue

but let me know cc @WanderingHogan

[WanderingHogan]

I think that this is a problem with devtools in chrome - i dont think all connection types are getting closed when you disable the connection.

This acts differently when you are on two different devices. Eventually the webrtc connection times out and shows both users are offline. I think that there are problems managing the webrtc connection that should be included in future tickets but we need to debug some things first.

If this ticket works otherwise and doesn't cause any crashes i think it can go in.