Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate error modal, welcome modal, and update modal #4726

Closed
josephmcg opened this issue Sep 12, 2022 · 1 comment · Fixed by #4942
Closed

consolidate error modal, welcome modal, and update modal #4726

josephmcg opened this issue Sep 12, 2022 · 1 comment · Fixed by #4942
Assignees
@nathan-power
Labels
backlog

Comments

@josephmcg
Copy link
Contributor

very similar structure, would make more sense to consolidate and allow props or templates.

error modal is more polished, use that as a base
@nathan-power nathan-power changed the title consolidate error modal and welcome modal consolidate error modal, welcome modal, and update modal Sep 16, 2022
@nathan-power
Copy link
Contributor

Note: make sure to add scroll container for body in case of long content

@nathan-power nathan-power mentioned this issue Sep 20, 2022
Merged
@nathan-power nathan-power linked a pull request Sep 20, 2022 that will close this issue
fix(modals): consolidate error modal, welcome modal, and update modal #4942
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathan-power nathan-power

Labels
backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(modals): consolidate error modal, welcome modal, and update modal Satellite-im/Core-PWA
2 participants
@josephmcg @nathan-power