From c9eed3ecd3264ff8e1fb646455d47edfed670a35 Mon Sep 17 00:00:00 2001 From: Herko Lategan Date: Mon, 24 Jul 2023 11:37:54 +0100 Subject: [PATCH] roachprod-microbench: fix delta string parsing A microbenchmark run, ran into an unexpected value for the delta string produced by the perf package. This change adds the "?" case so that all other values can be parsed correctly. Release note: None Epic: None --- pkg/cmd/roachprod-microbench/google/service.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cmd/roachprod-microbench/google/service.go b/pkg/cmd/roachprod-microbench/google/service.go index ca69de56651c..b3e4a214d1d2 100644 --- a/pkg/cmd/roachprod-microbench/google/service.go +++ b/pkg/cmd/roachprod-microbench/google/service.go @@ -212,7 +212,7 @@ func (srv *Service) createRawSheet( vals = append(vals, numCell(entry.Summaries[run].Center)) } delta := comparison.FormattedDelta - if delta == "~" { + if delta == "~" || delta == "?" { vals = append(vals, strCell(delta)) } else { vals = append(vals, percentCell(deltaToNum(delta)))