Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should OFI_USE_PROVIDER be removed? #1075

Open
wrrobin opened this issue Nov 9, 2022 · 1 comment
Open

Should OFI_USE_PROVIDER be removed? #1075

wrrobin opened this issue Nov 9, 2022 · 1 comment
Milestone
1.5.2

Comments

@wrrobin
Copy link
Collaborator

wrrobin commented Nov 9, 2022

It is mentioned as deprecated in shmem_env_defs.h and replaced by OFI_PROVIDER.
@wrrobin wrrobin changed the title Should we keep OFI_USE_PROVIDER? Should OFI_USE_PROVIDER be removed? Nov 9, 2022
@davidozog
Copy link
Member

Sure, please delete it.

Also as a side note, FI_PROVIDER seems to work identically to SHMEM_OFI_PROVIDER, but the latter can be handy I suppose.

@davidozog davidozog added this to the 1.5.2 milestone Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.2
Development

No branches or pull requests
2 participants
@davidozog @wrrobin