Seeking mode always uses exact seeks, causing slow mouse dragging

[Keith94]

mpv Information

built on Nov 20 2024 20:12:23

Reproduction Steps

Compared to other forks like ModernX from zydezu, ModernZ is noticeably more sluggish and struggles while scrubbing through a high bit rate 1080p file; the seek bar "lags" behind while it's trying to follow fast cursor movements.

So far I couldn't find any setting that would remedy that.

Expected Behavior

Equal performance when compared to modernX

Actual Behavior

Sluggish performance

Log File

log.txt

I carefully read all instructions and confirm that I did the following:

• I tested with the latest mpv version to validate that the issue is not already fixed.
• I provided all required information.

[Keith94]

I discovered the seekbar is (seemingly) always using exact seeks, which makes mouse dragging much slower, because the seekbarkeyframes and/or automatickeyframemode options appear to be broken.

So I reverted the commit 53c9d90 by adding back:

local function startupevents()
    if user_opts.automatickeyframemode then
        if mp.get_property_number("duration", 0) > user_opts.automatickeyframelimit then
            user_opts.seekbarkeyframes = true
        else
            user_opts.seekbarkeyframes = false
        end
    end
end

--
-- Other important stuff
mp.register_event("file-loaded", startupevents)

Remove the section:

	if user_opts.automatickeyframemode then
		if mp.get_property_number("duration", 0) > user_opts.automatickeyframelimit then
			user_opts.seekbarkeyframes = true
		else
			user_opts.seekbarkeyframes = false
		end
	end

And dragging is not slow anymore.

[Samillion]

I discovered the seekbar is (seemingly) always using exact seeks, which makes mouse dragging much slower, because the seekbarkeyframes and/or automatickeyframemode options appear to be broken.

So I reverted the commit 53c9d90 by adding back:

local function startupevents()
    if user_opts.automatickeyframemode then
        if mp.get_property_number("duration", 0) > user_opts.automatickeyframelimit then
            user_opts.seekbarkeyframes = true
        else
            user_opts.seekbarkeyframes = false
        end
    end
end

--
-- Other important stuff
mp.register_event("file-loaded", startupevents)

Remove the section:

	if user_opts.automatickeyframemode then
		if mp.get_property_number("duration", 0) > user_opts.automatickeyframelimit then
			user_opts.seekbarkeyframes = true
		else
			user_opts.seekbarkeyframes = false
		end
	end

And dragging is not slow anymore.

Ah, that is a great find. So it's being processed earlier than needed. Thanks for pointing this out, I'll post a fix in a bit to see if it fixes it.

[Samillion]

Could you try this, please:
https://github.com/Samillion/ModernZ/blob/dev_seekmode_fix/modernz.lua

Question: So for your scenario, setting automatickeyframemode to no makes it slow? Because that seems to be the case for me as well.

[Keith94]

Could you try this, please:
https://github.com/Samillion/ModernZ/blob/dev_seekmode_fix/modernz.lua

Will check later today. Thanks!

Question: So for your scenario, setting automatickeyframemode to no makes it slow? Because that seems to be the case for me as well.

Yep that's right. It will also be slow when seekbarkeyframes is turned off, if automatickeyframemode is also turned off.

[Keith94]

Everything's working properly now. :) ty