Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I found a case when it seems that the standard format does not decode #7

Closed
pavlo-kravchenko opened this issue Oct 18, 2022 · 9 comments
Labels
enhancement New feature or request

Comments

@pavlo-kravchenko
Copy link

This is one of the banks of the Darkest Dungeon game.
It's called music.bank.
You can write to me and I will reset the file itself.

@SamboyCoding
Copy link
Owner

I'd need a lot more info than this to start, for example any error you get, what internal format the bank is identified as, etc

@pavlo-kravchenko
Copy link
Author

I get just "Failed to extract sample"
MyBank!.Header.AudioType = 16 (from method RebuildAsStandardFileFormat)
What other information can I provide?

@SamboyCoding
Copy link
Owner

16 is a new file format, FADPCM. I would need the bank file to work investigate further.

@SamboyCoding SamboyCoding added the enhancement New feature or request label Oct 22, 2022
@pavlo-kravchenko
Copy link
Author

Where can I send it?

@SamboyCoding
Copy link
Owner

If you have discord you can communicate with me in the server I have for my projects https://discord.gg/XdggT7XZXm

@Devyatyi9
Copy link

Devyatyi9 commented Sep 2, 2023

@SamboyCoding Is there any news on FADPCM format? I know that fsbank.exe from FMOD Studio API can generate files with this format. Also fsb_aud_extr_1_10.exe (not from API) can read and decompress this format from fsb and convert to wav. There is also plugin for foobar2000 for playing different game formats, where there is support for Fmod bank and Fmod FSB5 FADPCM.
"FMOD Studio API Windows\bin\x64\fsbank.exe"
image.
https://www.fmod.com/download#fmodengine

@SamboyCoding
Copy link
Owner

Partial FADPCM support implemented in 9d93264 but it's not working properly yet

@ds5678
Copy link
Contributor

ds5678 commented Sep 2, 2023

I have a project that might help with implementing support for additional formats.

https://github.com/AssetRipper/WavToFsb

Though this line will need to be changed:

https://github.com/AssetRipper/WavToFsb/blob/cb5e4139a600573c8579bf7c826d64811a8f3eb0/WavToFsb/Program.cs#L35

@SamboyCoding
Copy link
Owner

The issue doesn't so much lie in having access to the files as much as it does demand. As detailed in the readme, most of the remaining unimplemented format simply do not get used often enough for it to be worth implementing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants