Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change null to None for python #54

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

deepankarm
Copy link
Contributor

Thanks for the awesome work with auto-swagger. I found an issue with null in swagger.py, replaced null with None & tested locally. Quite new to TS world, so apologies about not adding tests.

Another suggestion is, instead of writing swaggerPythonString to ./swagger/swagger.py, we should just serialize swaggerStr as a json into a file and do json.load(...) in the handler defined in swagger-json.py (This will take of handling booleans, nulls & other fields).

@bfaulk96
Copy link
Collaborator

bfaulk96 commented Mar 9, 2022

Another suggestion is, instead of writing swaggerPythonString to ./swagger/swagger.py, we should just serialize swaggerStr as a json into a file and do json.load(...) in the handler defined in swagger-json.py (This will take of handling booleans, nulls & other fields).

I like this suggestion a ton more than what we're currently doing for Python.
I'll look into implementing it.

@bfaulk96 bfaulk96 merged commit 447044d into completecoding:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants