Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws invalid version when using Node.js version alias in .travis.yml #46

Closed
sindresorhus opened this issue Aug 10, 2016 · 1 comment
Closed
Labels

Comments

@sindresorhus
Copy link

When I run it in the ansi-styles repo.

ansi-styles
TypeError: Invalid Version: stable.0.0
    at new SemVer (/usr/local/lib/node_modules/clinton/node_modules/semver/semver.js:293:11)
    at Range.test (/usr/local/lib/node_modules/clinton/node_modules/semver/semver.js:1036:15)
    at Function.satisfies (/usr/local/lib/node_modules/clinton/node_modules/semver/semver.js:1085:16)
    at /usr/local/lib/node_modules/clinton/rules/travis.js:97:17

Because of https://github.com/chalk/ansi-styles/blob/d8be37b078a14e35d27a7dbae3f9f5ae7dee9d72/.travis.yml#L4

Both stable, iojs, and node are valid aliases.

stable and iojs are deprecated, so would be useful if clinton warned about those.

@SamVerschueren
Copy link
Owner

Damn, totally missed those cases. Will fix it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants