utilize statscollector to estimate full table size #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtracers
requested changes
Mar 16, 2020
| @@ -312,6 +312,9 @@ def validate_code(self, key, value): | |||
| return value[:max_len] | |||
| return value | |||
|
|
|||
| def count_query(): | |||
| return "SELECT n_live_tup FROM pg_stat_all_tables WHERE relname = '%s'" % (Game.__table__.name) | |||
There was a problem hiding this comment.
I'm not a fan of this way if inserting the table names we should be able to do this in SQL alchemy without the need of a custom string.
There was a problem hiding this comment.
Totally agree, I'm really not a fan of this. I'll take another crack at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #433