From 083fd7372a2813cd6f7662e1be7228e194a7e31c Mon Sep 17 00:00:00 2001 From: Adam Raya Navarro Date: Thu, 19 Jan 2023 14:37:42 -0800 Subject: [PATCH 1/3] Update is not fork check --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d11228af86..fc2ad4891a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -21,7 +21,7 @@ on: schedule: - cron: 0 8 * * * env: - IS_NOT_FORK: ${{ github.repository == 'SalesforceCommerceCloud/pwa-kit' }} + IS_NOT_FORK: ${{ github.repository == github.event.pull_request.head.repo.full_name }} DEVELOP: ${{ github.repository == 'SalesforceCommerceCloud/pwa-kit' && github.ref == 'refs/heads/develop' }} RELEASE: ${{ github.repository == 'SalesforceCommerceCloud/pwa-kit' && startsWith(github.ref, 'refs/heads/release-') }} jobs: From bc2dc71f74b65bcd949378ba654e30e9bcccb9e0 Mon Sep 17 00:00:00 2001 From: Adam Raya Navarro Date: Thu, 19 Jan 2023 14:51:04 -0800 Subject: [PATCH 2/3] Add single quote to cron expression --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index fc2ad4891a..4a3a37cddf 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -19,7 +19,7 @@ on: # TODO: Should we run on all pushes to release branches, or should we run on GitHub releases? - 'release-*' schedule: - - cron: 0 8 * * * + - cron: '0 8 * * *' env: IS_NOT_FORK: ${{ github.repository == github.event.pull_request.head.repo.full_name }} DEVELOP: ${{ github.repository == 'SalesforceCommerceCloud/pwa-kit' && github.ref == 'refs/heads/develop' }} From 61fe660433bcfcb563739fdd64a6de0ac692e1ea Mon Sep 17 00:00:00 2001 From: Adam Raya Navarro Date: Thu, 19 Jan 2023 14:54:17 -0800 Subject: [PATCH 3/3] Add cron docs --- .github/workflows/test.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4a3a37cddf..4e6e599273 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -19,6 +19,7 @@ on: # TODO: Should we run on all pushes to release branches, or should we run on GitHub releases? - 'release-*' schedule: + # Run every day at 12pm (PST) - cron uses UTC times - cron: '0 8 * * *' env: IS_NOT_FORK: ${{ github.repository == github.event.pull_request.head.repo.full_name }}