[App Extensibility ⚙️] Remove Name Spacing from Store Locator Extension #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraya
reviewed
Nov 28, 2024
There was a problem hiding this comment.
Nit update the console.log message to extension-chakra-store-locator
There was a problem hiding this comment.
Also, in this file, there are imports that need to be fixed. That's why if typescript-minimal uses the store-locator extension, the project will not load and it returns a ModuleNotFound error.
adamraya
approved these changes
Nov 28, 2024
vmarta
reviewed
Dec 2, 2024
| @@ -43,7 +43,7 @@ The Store Locator extension is configured via the `mobify.app.extensions` proper | |||
| "app": { | |||
| "extensions": [ | |||
| [ | |||
| "@salesforce/extension-store-locator", | |||
| "@salesforce/extension-chakra-store-locator", | |||
There was a problem hiding this comment.
Near the bottom of this readme, there are file paths that need to be updated too.
There was a problem hiding this comment.
Also, in this file, there are imports that need to be fixed. That's why if typescript-minimal uses the store-locator extension, the project will not load and it returns a ModuleNotFound error.
bendvc
changed the title
vmarta
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the opinionated name spacing in the store-locator extension project. This name spacing was used to prevent possible unexpected override collisions. But this wasn't a good solution because it relies on the extension developer to name their files and folders in a certain way. We are instead going to change how the
buildCandidatePathsresolver util works so that the name spacing occurs there, this means the extension developer won't have any need to name their folders with prefixes to prevent collisions, it will be resolved internally.Related PR #2154