Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Extensibility] Fix tests #2150

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[App Extensibility] Fix tests #2150

merged 1 commit into from
Nov 26, 2024

Conversation

kevinxh
Copy link
Collaborator

@kevinxh kevinxh commented Nov 26, 2024

It appears some tests from extension-chakra-storefront is failing, this PR tries to fix the failed tests from that package.

CleanShot 2024-11-26 at 14 49 21

changes

  • remove the empty _app and _app-config tests
  • fix the assertions in with-currency.test.tsx

@kevinxh kevinxh requested a review from a team as a code owner November 26, 2024 22:50
@kevinxh kevinxh merged commit 57b9c00 into feature/extensibility-v2 Nov 26, 2024
9 of 29 checks passed
@kevinxh kevinxh deleted the fix-tests branch November 26, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants