Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Node v16.x #795

Closed
benramsay opened this issue Oct 26, 2022 · 2 comments · Fixed by #965
Closed

[BUG] Node v16.x #795

benramsay opened this issue Oct 26, 2022 · 2 comments · Fixed by #965
Labels
Acknowledged Team has responded to issue

Comments

@benramsay
Copy link

benramsay commented Oct 26, 2022

Summary

As described by the quick start, we are asked to use : Node 14.x and NPM 6.14.x.
But I am using other library asking for : Node : v16.14.0 and NPM : 8.14.0
If I go with the second configuration it is not working and gives me the following ERROR.

Steps To Reproduce

USING : Node : v16.14.0 and NPM : 8.14.0

npx pwa-kit-create-app@latest --preset retail-react-app-demo
cd pwa-kit-starter-project
npm start

ERROR

SyntaxError: The "req1-ssr-overall-start" performance mark has not been set
at getMark (node:internal/perf/usertiming:54:11)
at calculateStartDuration (node:internal/perf/usertiming:137:13)
at EventTarget.measure (node:internal/perf/usertiming:155:7)
at PerformanceTimer.end (D:\Work\ToTest\salesforce\pwa-kit-starter-project\node_modules\pwa-kit-runtime\utils\ssr-server\performance-timer.js:117:29)
at ServerResponse.done (D:\Work\ToTest\salesforce\pwa-kit-starter-project\node_modules\pwa-kit-runtime\ssr\server\build-remote-server.js:909:11) at ServerResponse.emit (node:events:532:35)
at onFinish (node:_http_outgoing:830:10) at afterWrite (node:internal/streams/writable:497:5)
at afterWriteTick (node:internal/streams/writable:484:10)
at processTicksAndRejections (node:internal/process/task_queues:82:21)
Command failed: node D:\Work\ToTest\salesforce\pwa-kit-starter-project\app\ssr.js

@benramsay benramsay changed the title [BUG] [BUG] Quick start Oct 26, 2022
@benramsay benramsay changed the title [BUG] Quick start [BUG] Node : v16.14.0 Oct 26, 2022
@benramsay benramsay changed the title [BUG] Node : v16.14.0 [BUG] Node v16.14.0 Oct 26, 2022
@benramsay benramsay changed the title [BUG] Node v16.14.0 [BUG] Node v16.x Oct 26, 2022
@kevinxh
Copy link
Collaborator

kevinxh commented Oct 26, 2022

Hey @benramsay , thanks for reporting this! Unfortunately this is a known issue with Node v16 at the moment. It's on our roadmap to support node 16 soon. I'll come back to this issue when this is fixed. Thanks for your patience!

@kevinxh kevinxh added the Acknowledged Team has responded to issue label Oct 26, 2022
@bfeister
Copy link
Collaborator

This is in active development now with @raiyaj #965

@bfeister bfeister linked a pull request Feb 10, 2023 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acknowledged Team has responded to issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants