Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Roadmap for ReactQuery and ServerContext features #721

Closed
nx-renezwinge opened this issue Sep 16, 2022 · 3 comments
Closed

[QUESTION] Roadmap for ReactQuery and ServerContext features #721

nx-renezwinge opened this issue Sep 16, 2022 · 3 comments
Labels
Acknowledged Team has responded to issue

Comments

@nx-renezwinge
Copy link

Hello everybody,
we are looking every time over new PRs in the PWA Kit project to see the road of the project, especially TechStack wise.
So we saw the use of ReactQuery for commerce-sdk-react and the new ServerContext to replace getProps in future.

This is a really good decision and for a current running customer project, we refactored our PageDesigner integration and THIRD Party API integrations to use ReactQuery.

But currently the SSR part with Hydration is missing in the PWA-Kit implementation. I see in the PRs you are working on this. Will these features coming with the next release?

Thx.

Best regards René

@bendvc
Copy link
Collaborator

bendvc commented Sep 16, 2022

Hey René!

Short answer is YES.

Long answer. The release is expected at the end of 242 for server-side support of ReactQuery integration with the PWA-Kit SDK. We have many POC's showing the server rendering working, but we are just working on settling the API that we think is going to be best for this feature. There are many things we have to take into account when adding react-query support to the rendering pipeline. Things like feature parity with getProps, hence the inclusion of a new hook for getting the server context to set statuses of your responses and whatnot. The thing that is taking the most time is the sheer amount to refactoring in the rendering pipeline that we need to do to pull getProps out and make it plugable so that for those upgrading to the next version of the SDK, they can still use the legacy getProps.

@bendvc bendvc added the Acknowledged Team has responded to issue label Sep 16, 2022
@ecRobertEngel
Copy link
Contributor

Hey. Just a very minor question. What is meant by The release is expected at the end of 242 ? Might be a language barrier kicking in.

@adamraya
Copy link
Collaborator

adamraya commented Oct 31, 2022

Thank you @nx-renezwinge and @ecRobertEngel for your patience.

The change was implemented in #724 and released in v2.3.0.

The Upgrade to 2.3 guide details the steps to get you started using react-query in projects generated prior to v2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Acknowledged Team has responded to issue
Projects
None yet
Development

No branches or pull requests

4 participants