From 59b8a18d31aff3dbe0116d240d6c7c3d2bb4a137 Mon Sep 17 00:00:00 2001 From: Kevin He Date: Tue, 16 Apr 2024 10:54:44 -0700 Subject: [PATCH] Release 3.5.0 - SLAS Private Client Support (#1747) * bump version to 3.5.0 and update CHANGELOGs * fix versions and changelogs * fix lock file versions * fix package version * fix package version 2 * use npm on both win and mac platforms * Revert "use npm on both win and mac platforms" This reverts commit 63b402f62421c8d1fd2ef710622cec4a90af494d. * debug ci * try shell:true * more shell:true * Update scripts/check-version.js Signed-off-by: Kevin He --------- Signed-off-by: Kevin He --- lerna.json | 2 +- package-lock.json | 4 ++-- package.json | 2 +- packages/commerce-sdk-react/CHANGELOG.md | 2 +- packages/commerce-sdk-react/package-lock.json | 4 ++-- packages/commerce-sdk-react/package.json | 6 ++--- packages/internal-lib-build/package-lock.json | 4 ++-- packages/internal-lib-build/package.json | 4 ++-- packages/pwa-kit-create-app/CHANGELOG.md | 2 +- packages/pwa-kit-create-app/package-lock.json | 4 ++-- packages/pwa-kit-create-app/package.json | 6 ++--- .../scripts/create-mobify-app-dev.js | 2 +- packages/pwa-kit-dev/CHANGELOG.md | 9 +++---- packages/pwa-kit-dev/package-lock.json | 4 ++-- packages/pwa-kit-dev/package.json | 6 ++--- packages/pwa-kit-react-sdk/CHANGELOG.md | 5 ++-- packages/pwa-kit-react-sdk/package-lock.json | 4 ++-- packages/pwa-kit-react-sdk/package.json | 8 +++---- packages/pwa-kit-runtime/CHANGELOG.md | 5 ++-- packages/pwa-kit-runtime/package-lock.json | 4 ++-- packages/pwa-kit-runtime/package.json | 8 +++---- .../package-lock.json | 4 ++-- .../template-express-minimal/package.json | 6 ++--- .../package-lock.json | 4 ++-- .../template-mrt-reference-app/package.json | 6 ++--- .../template-retail-react-app/CHANGELOG.md | 7 ++++-- .../package-lock.json | 4 ++-- .../template-retail-react-app/package.json | 10 ++++---- .../package-lock.json | 4 ++-- .../template-typescript-minimal/package.json | 8 +++---- .../test-commerce-sdk-react/package-lock.json | 4 ++-- packages/test-commerce-sdk-react/package.json | 12 +++++----- scripts/check-version.js | 24 +++++++++++-------- 33 files changed, 97 insertions(+), 91 deletions(-) diff --git a/lerna.json b/lerna.json index 1c58bb3d29..235bb67603 100644 --- a/lerna.json +++ b/lerna.json @@ -1,5 +1,5 @@ { - "version": "3.5.0-alpha.1", + "version": "3.5.0", "packages": [ "packages/*" ] diff --git a/package-lock.json b/package-lock.json index 7fba1245db..1ba14d96fb 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "pwa-kit", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "pwa-kit", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "hasInstallScript": true, "dependencies": { "node-fetch": "^2.6.9" diff --git a/package.json b/package.json index bae761defe..2b0cd3a844 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "pwa-kit", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "scripts": { "bump-version": "node ./scripts/bump-version/index.js", "bump-version:retail-react-app": "node ./scripts/bump-version/index.js --package=@salesforce/retail-react-app", diff --git a/packages/commerce-sdk-react/CHANGELOG.md b/packages/commerce-sdk-react/CHANGELOG.md index 35eda08694..d90921c85a 100644 --- a/packages/commerce-sdk-react/CHANGELOG.md +++ b/packages/commerce-sdk-react/CHANGELOG.md @@ -1,4 +1,4 @@ -## v1.4.0-dev (Jan 22, 2024) +## v1.4.0 (Apr 15, 2024) - Add Support for SLAS private flow [#1722](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1722) - Fix invalid query params warnings and allow custom query [#1655](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1655) diff --git a/packages/commerce-sdk-react/package-lock.json b/packages/commerce-sdk-react/package-lock.json index 162a6f3d9c..25b4d2a236 100644 --- a/packages/commerce-sdk-react/package-lock.json +++ b/packages/commerce-sdk-react/package-lock.json @@ -1,12 +1,12 @@ { "name": "@salesforce/commerce-sdk-react", - "version": "1.4.0-dev.1", + "version": "1.4.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@salesforce/commerce-sdk-react", - "version": "1.4.0-dev.1", + "version": "1.4.0", "license": "See license in LICENSE", "dependencies": { "commerce-sdk-isomorphic": "^1.13.1", diff --git a/packages/commerce-sdk-react/package.json b/packages/commerce-sdk-react/package.json index dfa2217ab8..6b390ed4bd 100644 --- a/packages/commerce-sdk-react/package.json +++ b/packages/commerce-sdk-react/package.json @@ -1,6 +1,6 @@ { "name": "@salesforce/commerce-sdk-react", - "version": "1.4.0-dev.1", + "version": "1.4.0", "description": "A library that provides react hooks for fetching data from Commerce Cloud", "homepage": "https://github.com/SalesforceCommerceCloud/pwa-kit/tree/develop/packages/ecom-react-hooks#readme", "bugs": { @@ -45,7 +45,7 @@ "jwt-decode": "^4.0.0" }, "devDependencies": { - "@salesforce/pwa-kit-dev": "3.5.0-alpha.1", + "@salesforce/pwa-kit-dev": "3.5.0", "@tanstack/react-query": "^4.28.0", "@testing-library/jest-dom": "^5.16.5", "@testing-library/react": "^14.0.0", @@ -59,7 +59,7 @@ "@types/react-helmet": "~6.1.6", "@types/react-router-dom": "~5.3.3", "cross-env": "^5.2.1", - "internal-lib-build": "3.5.0-alpha.1", + "internal-lib-build": "3.5.0", "jsonwebtoken": "^9.0.0", "nock": "^13.3.0", "nodemon": "^2.0.22", diff --git a/packages/internal-lib-build/package-lock.json b/packages/internal-lib-build/package-lock.json index e6d00d2980..4c7bdabffd 100644 --- a/packages/internal-lib-build/package-lock.json +++ b/packages/internal-lib-build/package-lock.json @@ -1,12 +1,12 @@ { "name": "internal-lib-build", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "internal-lib-build", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "license": "SEE LICENSE IN LICENSE", "dependencies": { "@babel/cli": "^7.21.0", diff --git a/packages/internal-lib-build/package.json b/packages/internal-lib-build/package.json index c91bba14ad..849132030c 100644 --- a/packages/internal-lib-build/package.json +++ b/packages/internal-lib-build/package.json @@ -1,6 +1,6 @@ { "name": "internal-lib-build", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "private": true, "description": "Build tools for *libraries* in the monorepo", "bugs": { @@ -60,7 +60,7 @@ "shelljs": "^0.8.5" }, "devDependencies": { - "@salesforce/pwa-kit-dev": "3.5.0-alpha.1", + "@salesforce/pwa-kit-dev": "3.5.0", "npm-packlist": "^4.0.0", "typescript": "4.9.5" }, diff --git a/packages/pwa-kit-create-app/CHANGELOG.md b/packages/pwa-kit-create-app/CHANGELOG.md index 9b3890dbfb..bf3576b195 100644 --- a/packages/pwa-kit-create-app/CHANGELOG.md +++ b/packages/pwa-kit-create-app/CHANGELOG.md @@ -1,4 +1,4 @@ -## v3.5.0-dev (Jan 22, 2024) +## v3.5.0 (Apr 15, 2024) - Add Support for SLAS private flow [#1722](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1722) diff --git a/packages/pwa-kit-create-app/package-lock.json b/packages/pwa-kit-create-app/package-lock.json index 795ce8c29a..4244e2c28f 100644 --- a/packages/pwa-kit-create-app/package-lock.json +++ b/packages/pwa-kit-create-app/package-lock.json @@ -1,12 +1,12 @@ { "name": "@salesforce/pwa-kit-create-app", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@salesforce/pwa-kit-create-app", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "license": "See license in LICENSE", "dependencies": { "commander": "^9.5.0", diff --git a/packages/pwa-kit-create-app/package.json b/packages/pwa-kit-create-app/package.json index 8a15414f34..42a3a7b410 100644 --- a/packages/pwa-kit-create-app/package.json +++ b/packages/pwa-kit-create-app/package.json @@ -1,6 +1,6 @@ { "name": "@salesforce/pwa-kit-create-app", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "description": "Salesforce's project generator tool", "homepage": "https://github.com/SalesforceCommerceCloud/pwa-kit/tree/develop/packages/pwa-kit-create-app#readme", "bugs": { @@ -38,8 +38,8 @@ "tar": "^6.2.1" }, "devDependencies": { - "@salesforce/pwa-kit-dev": "3.5.0-alpha.1", - "internal-lib-build": "3.5.0-alpha.1", + "@salesforce/pwa-kit-dev": "3.5.0", + "internal-lib-build": "3.5.0", "verdaccio": "^5.22.1" }, "engines": { diff --git a/packages/pwa-kit-create-app/scripts/create-mobify-app-dev.js b/packages/pwa-kit-create-app/scripts/create-mobify-app-dev.js index 04a82418c1..ad368593de 100755 --- a/packages/pwa-kit-create-app/scripts/create-mobify-app-dev.js +++ b/packages/pwa-kit-create-app/scripts/create-mobify-app-dev.js @@ -125,7 +125,7 @@ const runGenerator = () => { const extension = process.platform === 'win32' ? '.cmd' : '' const npm = `npm${extension}` - const foundNpm = cp.spawnSync(npm, ['-v']).stdout.toString().trim() + const foundNpm = cp.spawnSync(npm, ['-v'], {shell: true}).stdout.toString().trim() const flags = semver.satisfies(foundNpm, '>=7') ? '-y' : '' const pathToNpxCache = p.join(sh.exec('npm config get cache', {silent: true}).trim(), '_npx') diff --git a/packages/pwa-kit-dev/CHANGELOG.md b/packages/pwa-kit-dev/CHANGELOG.md index 31979d0765..95d3b78176 100644 --- a/packages/pwa-kit-dev/CHANGELOG.md +++ b/packages/pwa-kit-dev/CHANGELOG.md @@ -1,9 +1,10 @@ -## v3.5.0-alpha.1 (Apr 10, 2024) -## v3.5.0-dev.1 (Mar 22, 2024) -## v3.5.0-dev (Jan 22, 2024) -## v3.4.0 (Jan 19, 2024) +## v3.5.0 (Apr 15, 2024) - Add Support for SLAS private flow [#1722](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1722) + + +## v3.4.0 (Jan 19, 2024) + - Add support for node 20 [#1612](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1612) ## v3.3.0 (Dec 08, 2023) diff --git a/packages/pwa-kit-dev/package-lock.json b/packages/pwa-kit-dev/package-lock.json index cb1d5456cc..c21d68cbd7 100644 --- a/packages/pwa-kit-dev/package-lock.json +++ b/packages/pwa-kit-dev/package-lock.json @@ -1,12 +1,12 @@ { "name": "@salesforce/pwa-kit-dev", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@salesforce/pwa-kit-dev", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "license": "SEE LICENSE IN LICENSE", "dependencies": { "@babel/cli": "^7.21.0", diff --git a/packages/pwa-kit-dev/package.json b/packages/pwa-kit-dev/package.json index b4e97a741a..f997bdc529 100644 --- a/packages/pwa-kit-dev/package.json +++ b/packages/pwa-kit-dev/package.json @@ -1,6 +1,6 @@ { "name": "@salesforce/pwa-kit-dev", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "description": "Build tools for pwa-kit", "homepage": "https://github.com/SalesforceCommerceCloud/pwa-kit/tree/develop/packages/pwa-kit-dev#readme", "bugs": { @@ -58,7 +58,7 @@ "@loadable/server": "^5.15.3", "@loadable/webpack-plugin": "^5.15.2", "@pmmmwh/react-refresh-webpack-plugin": "^0.5.10", - "@salesforce/pwa-kit-runtime": "3.5.0-alpha.1", + "@salesforce/pwa-kit-runtime": "3.5.0", "@typescript-eslint/eslint-plugin": "^5.57.0", "@typescript-eslint/parser": "^5.57.0", "archiver": "1.3.0", @@ -121,7 +121,7 @@ "@types/node": "~16.0.3", "@types/node-fetch": "~2.6.3", "@types/validator": "~13.7.14", - "internal-lib-build": "3.5.0-alpha.1", + "internal-lib-build": "3.5.0", "nock": "^13.3.0", "nodemon": "^2.0.22", "superagent": "^6.1.0", diff --git a/packages/pwa-kit-react-sdk/CHANGELOG.md b/packages/pwa-kit-react-sdk/CHANGELOG.md index c7f6adb893..533f5abd76 100644 --- a/packages/pwa-kit-react-sdk/CHANGELOG.md +++ b/packages/pwa-kit-react-sdk/CHANGELOG.md @@ -1,6 +1,5 @@ -## v3.5.0-alpha.1 (Apr 10, 2024) -## v3.5.0-dev.1 (Mar 22, 2024) -## v3.5.0-dev (Jan 22, 2024) +## v3.5.0 (Apr 15, 2024) + ## v3.4.0 (Jan 19, 2024) - Add support for node 20 [#1612](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1612) diff --git a/packages/pwa-kit-react-sdk/package-lock.json b/packages/pwa-kit-react-sdk/package-lock.json index 6d64afcfc9..4481688d76 100644 --- a/packages/pwa-kit-react-sdk/package-lock.json +++ b/packages/pwa-kit-react-sdk/package-lock.json @@ -1,12 +1,12 @@ { "name": "@salesforce/pwa-kit-react-sdk", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@salesforce/pwa-kit-react-sdk", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "license": "SEE LICENSE IN LICENSE", "dependencies": { "@loadable/babel-plugin": "^5.15.3", diff --git a/packages/pwa-kit-react-sdk/package.json b/packages/pwa-kit-react-sdk/package.json index e8810189a7..269cca9fe1 100644 --- a/packages/pwa-kit-react-sdk/package.json +++ b/packages/pwa-kit-react-sdk/package.json @@ -1,6 +1,6 @@ { "name": "@salesforce/pwa-kit-react-sdk", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "description": "A library that supports the isomorphic React rendering pipeline for Commerce Cloud Managed Runtime apps", "homepage": "https://github.com/SalesforceCommerceCloud/pwa-kit/tree/develop/packages/pwa-kit-react-sdk#readme", "bugs": { @@ -37,7 +37,7 @@ "@loadable/babel-plugin": "^5.15.3", "@loadable/server": "^5.15.3", "@loadable/webpack-plugin": "^5.15.2", - "@salesforce/pwa-kit-runtime": "3.5.0-alpha.1", + "@salesforce/pwa-kit-runtime": "3.5.0", "@tanstack/react-query": "^4.28.0", "cross-env": "^5.2.1", "event-emitter": "^0.3.5", @@ -50,11 +50,11 @@ }, "devDependencies": { "@loadable/component": "^5.15.3", - "@salesforce/pwa-kit-dev": "3.5.0-alpha.1", + "@salesforce/pwa-kit-dev": "3.5.0", "@testing-library/jest-dom": "^5.16.5", "@testing-library/react": "^14.0.0", "@testing-library/user-event": "^14.4.3", - "internal-lib-build": "3.5.0-alpha.1", + "internal-lib-build": "3.5.0", "node-html-parser": "^3.3.6", "nodemon": "^2.0.22", "react": "^18.2.0", diff --git a/packages/pwa-kit-runtime/CHANGELOG.md b/packages/pwa-kit-runtime/CHANGELOG.md index ec9d3a2622..6a2575b90e 100644 --- a/packages/pwa-kit-runtime/CHANGELOG.md +++ b/packages/pwa-kit-runtime/CHANGELOG.md @@ -1,6 +1,5 @@ -## v3.5.0-alpha.1 (Apr 10, 2024) -## v3.5.0-dev.1 (Mar 22, 2024) -## v3.5.0-dev (Jan 22, 2024) +## v3.5.0 (Apr 15, 2024) + ## v3.4.0 (Jan 19, 2024) - Add Support for SLAS private flow [#1722](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1722) diff --git a/packages/pwa-kit-runtime/package-lock.json b/packages/pwa-kit-runtime/package-lock.json index ee8421e952..31875ba141 100644 --- a/packages/pwa-kit-runtime/package-lock.json +++ b/packages/pwa-kit-runtime/package-lock.json @@ -1,12 +1,12 @@ { "name": "@salesforce/pwa-kit-runtime", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@salesforce/pwa-kit-runtime", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "license": "SEE LICENSE IN LICENSE", "dependencies": { "@loadable/babel-plugin": "^5.15.3", diff --git a/packages/pwa-kit-runtime/package.json b/packages/pwa-kit-runtime/package.json index ecf74bf24e..95426def2e 100644 --- a/packages/pwa-kit-runtime/package.json +++ b/packages/pwa-kit-runtime/package.json @@ -1,6 +1,6 @@ { "name": "@salesforce/pwa-kit-runtime", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "description": "The PWAKit Runtime", "homepage": "https://github.com/SalesforceCommerceCloud/pwa-kit/tree/develop/packages/pwa-kit-runtime#readme", "bugs": { @@ -46,11 +46,11 @@ }, "devDependencies": { "@loadable/component": "^5.15.3", - "@salesforce/pwa-kit-dev": "3.5.0-alpha.1", + "@salesforce/pwa-kit-dev": "3.5.0", "@serverless/event-mocks": "^1.1.1", "aws-lambda-mock-context": "^3.2.1", "fs-extra": "^11.1.1", - "internal-lib-build": "3.5.0-alpha.1", + "internal-lib-build": "3.5.0", "nock": "^13.3.0", "nodemon": "^2.0.22", "sinon": "^13.0.2", @@ -58,7 +58,7 @@ "supertest": "^4.0.2" }, "peerDependencies": { - "@salesforce/pwa-kit-dev": "3.5.0-alpha.1" + "@salesforce/pwa-kit-dev": "3.5.0" }, "peerDependenciesMeta": { "@salesforce/pwa-kit-dev": { diff --git a/packages/template-express-minimal/package-lock.json b/packages/template-express-minimal/package-lock.json index 4c8975aa40..c5b83524d8 100644 --- a/packages/template-express-minimal/package-lock.json +++ b/packages/template-express-minimal/package-lock.json @@ -1,12 +1,12 @@ { "name": "template-express-minimal", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "template-express-minimal", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "license": "See license in LICENSE", "devDependencies": { "supertest": "^4.0.2" diff --git a/packages/template-express-minimal/package.json b/packages/template-express-minimal/package.json index bb904d5544..5559ed537c 100644 --- a/packages/template-express-minimal/package.json +++ b/packages/template-express-minimal/package.json @@ -1,6 +1,6 @@ { "name": "template-express-minimal", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "private": true, "license": "See license in LICENSE", "scripts": { @@ -15,8 +15,8 @@ "test": "pwa-kit-dev test" }, "devDependencies": { - "@salesforce/pwa-kit-dev": "3.5.0-alpha.1", - "@salesforce/pwa-kit-runtime": "3.5.0-alpha.1", + "@salesforce/pwa-kit-dev": "3.5.0", + "@salesforce/pwa-kit-runtime": "3.5.0", "supertest": "^4.0.2" }, "mobify": { diff --git a/packages/template-mrt-reference-app/package-lock.json b/packages/template-mrt-reference-app/package-lock.json index 1121bd4cf4..b7cb7b8a3c 100644 --- a/packages/template-mrt-reference-app/package-lock.json +++ b/packages/template-mrt-reference-app/package-lock.json @@ -1,12 +1,12 @@ { "name": "template-mrt-reference-app", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "template-mrt-reference-app", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "license": "See license in LICENSE", "dependencies": { "@aws-sdk/client-cloudwatch-logs": "^3.450.0", diff --git a/packages/template-mrt-reference-app/package.json b/packages/template-mrt-reference-app/package.json index dace5c56cd..c2346b1bf9 100644 --- a/packages/template-mrt-reference-app/package.json +++ b/packages/template-mrt-reference-app/package.json @@ -1,6 +1,6 @@ { "name": "template-mrt-reference-app", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "private": true, "license": "See license in LICENSE", "scripts": { @@ -16,8 +16,8 @@ }, "devDependencies": { "@loadable/component": "^5.15.3", - "@salesforce/pwa-kit-dev": "3.5.0-alpha.1", - "@salesforce/pwa-kit-runtime": "3.5.0-alpha.1", + "@salesforce/pwa-kit-dev": "3.5.0", + "@salesforce/pwa-kit-runtime": "3.5.0", "@smithy/smithy-client": "^2.1.15", "aws-sdk-client-mock": "^3.0.0", "cross-fetch": "^3.1.4", diff --git a/packages/template-retail-react-app/CHANGELOG.md b/packages/template-retail-react-app/CHANGELOG.md index af74670e8e..a8624b40c2 100644 --- a/packages/template-retail-react-app/CHANGELOG.md +++ b/packages/template-retail-react-app/CHANGELOG.md @@ -1,8 +1,11 @@ -## v2.4.0-dev (Jan 22, 2024) +## v2.4.0 (Apr 15, 2024) -### Bug Fixes +### New Feature - Add Support for SLAS private flow [#1722](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1722) + +### Bug Fixes + - Fix promo codes not being properly applied in cart [#1692](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1692) - Fix checkout shipping method fetching [#1693](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1693) - Fix invalid query params warnings [#1655](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/1655) diff --git a/packages/template-retail-react-app/package-lock.json b/packages/template-retail-react-app/package-lock.json index eca6a47761..3584731b65 100644 --- a/packages/template-retail-react-app/package-lock.json +++ b/packages/template-retail-react-app/package-lock.json @@ -1,12 +1,12 @@ { "name": "@salesforce/retail-react-app", - "version": "2.4.0-dev.1", + "version": "2.4.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@salesforce/retail-react-app", - "version": "2.4.0-dev.1", + "version": "2.4.0", "license": "See license in LICENSE", "dependencies": { "@chakra-ui/icons": "^2.0.19", diff --git a/packages/template-retail-react-app/package.json b/packages/template-retail-react-app/package.json index cc38d13f19..1c604bb409 100644 --- a/packages/template-retail-react-app/package.json +++ b/packages/template-retail-react-app/package.json @@ -1,6 +1,6 @@ { "name": "@salesforce/retail-react-app", - "version": "2.4.0-dev.1", + "version": "2.4.0", "license": "See license in LICENSE", "author": "cc-pwa-kit@salesforce.com", "ccExtensibility": { @@ -45,10 +45,10 @@ "@lhci/cli": "^0.11.0", "@loadable/component": "^5.15.3", "@peculiar/webcrypto": "^1.4.2", - "@salesforce/commerce-sdk-react": "1.4.0-dev.1", - "@salesforce/pwa-kit-dev": "3.5.0-alpha.1", - "@salesforce/pwa-kit-react-sdk": "3.5.0-alpha.1", - "@salesforce/pwa-kit-runtime": "3.5.0-alpha.1", + "@salesforce/commerce-sdk-react": "1.4.0", + "@salesforce/pwa-kit-dev": "3.5.0", + "@salesforce/pwa-kit-react-sdk": "3.5.0", + "@salesforce/pwa-kit-runtime": "3.5.0", "@tanstack/react-query": "^4.28.0", "@tanstack/react-query-devtools": "^4.29.1", "@testing-library/dom": "^9.0.1", diff --git a/packages/template-typescript-minimal/package-lock.json b/packages/template-typescript-minimal/package-lock.json index 5717dd93e9..6d52a9c3a2 100644 --- a/packages/template-typescript-minimal/package-lock.json +++ b/packages/template-typescript-minimal/package-lock.json @@ -1,12 +1,12 @@ { "name": "typescript-minimal", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "typescript-minimal", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "devDependencies": { "@loadable/component": "^5.15.3", "@tanstack/react-query": "^4.28.0", diff --git a/packages/template-typescript-minimal/package.json b/packages/template-typescript-minimal/package.json index 9255d89166..415bcda17b 100644 --- a/packages/template-typescript-minimal/package.json +++ b/packages/template-typescript-minimal/package.json @@ -1,6 +1,6 @@ { "name": "typescript-minimal", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "private": true, "scripts": { "build": "pwa-kit-dev build", @@ -18,9 +18,9 @@ }, "devDependencies": { "@loadable/component": "^5.15.3", - "@salesforce/pwa-kit-dev": "3.5.0-alpha.1", - "@salesforce/pwa-kit-react-sdk": "3.5.0-alpha.1", - "@salesforce/pwa-kit-runtime": "3.5.0-alpha.1", + "@salesforce/pwa-kit-dev": "3.5.0", + "@salesforce/pwa-kit-react-sdk": "3.5.0", + "@salesforce/pwa-kit-runtime": "3.5.0", "@tanstack/react-query": "^4.28.0", "@types/loadable__component": "~5.13.4", "@types/react": "~18.2.0", diff --git a/packages/test-commerce-sdk-react/package-lock.json b/packages/test-commerce-sdk-react/package-lock.json index b503a21928..a78b525c2e 100644 --- a/packages/test-commerce-sdk-react/package-lock.json +++ b/packages/test-commerce-sdk-react/package-lock.json @@ -1,12 +1,12 @@ { "name": "test-commerce-sdk-react", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "test-commerce-sdk-react", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "devDependencies": { "@loadable/component": "^5.15.3", "@tanstack/react-query": "^4.28.0", diff --git a/packages/test-commerce-sdk-react/package.json b/packages/test-commerce-sdk-react/package.json index 5632864a70..b2b34ac97e 100644 --- a/packages/test-commerce-sdk-react/package.json +++ b/packages/test-commerce-sdk-react/package.json @@ -1,6 +1,6 @@ { "name": "test-commerce-sdk-react", - "version": "3.5.0-alpha.1", + "version": "3.5.0", "private": true, "scripts": { "build": "pwa-kit-dev build", @@ -18,17 +18,17 @@ }, "devDependencies": { "@loadable/component": "^5.15.3", - "@salesforce/commerce-sdk-react": "1.4.0-dev.1", - "@salesforce/pwa-kit-dev": "3.5.0-alpha.1", - "@salesforce/pwa-kit-react-sdk": "3.5.0-alpha.1", - "@salesforce/pwa-kit-runtime": "3.5.0-alpha.1", + "@salesforce/commerce-sdk-react": "1.4.0", + "@salesforce/pwa-kit-dev": "3.5.0", + "@salesforce/pwa-kit-react-sdk": "3.5.0", + "@salesforce/pwa-kit-runtime": "3.5.0", "@tanstack/react-query": "^4.28.0", "@types/loadable__component": "~5.13.4", "@types/node": "~16.0.3", "@types/react": "~18.2.0", "@types/react-dom": "~18.2.1", "@types/react-router-dom": "~5.3.3", - "internal-lib-build": "3.5.0-alpha.1", + "internal-lib-build": "3.5.0", "react": "^18.2.0", "react-dom": "^18.2.0", "react-helmet": "^6.1.0", diff --git a/scripts/check-version.js b/scripts/check-version.js index 5b2e15f2f2..6863e66292 100755 --- a/scripts/check-version.js +++ b/scripts/check-version.js @@ -26,22 +26,26 @@ const spawnSync = (...args) => { } if (!fs.existsSync(path.join('node_modules', 'semver'))) { - spawnSync(npm, [ - 'install', - `semver@${pkg.devDependencies['semver']}`, - '--loglevel=silent', - '--no-save', - '--no-package-lock', - '--ignore-scripts', - '--no-audit' - ]) + spawnSync( + npm, + [ + 'install', + `semver@${pkg.devDependencies['semver']}`, + '--loglevel=silent', + '--no-save', + '--no-package-lock', + '--ignore-scripts', + '--no-audit' + ], + {shell: true} + ) } const semver = require('semver') const requiredNode = pkg.engines.node const foundNode = process.version const requiredNpm = pkg.engines.npm -const foundNpm = spawnSync(npm, ['-v']).stdout.toString().trim() +const foundNpm = spawnSync(npm, ['-v'], {shell: true}).stdout.toString().trim() const warnings = []