Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu-item): ensure consistent padding within menu-full-screen #7088

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

nuria1110
Copy link
Contributor

When maxWidth is set on menu-item within menu-full-screen, paddings are insconsistent. This fix ensures paddings are consistent, and maxWidth should have no effect in a menu-full-screen.

fix #7078

Proposed behaviour

Paddings are consistent across all MenuItems.

Current behaviour

Inconsistent paddings on MenuItem within a MenuFullScreen when maxWidth is set.

image

image

image

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

  • See added test story "Menu Full Screen with Max Width"

When maxWidth is set on menu-item within menu-full-screen, paddings are insconsistent. This fix
ensures paddings are consistent, and maxWidth should have no effect in a menu-full-screen.

fix #7078
@DipperTheDan DipperTheDan self-requested a review November 22, 2024 13:47
@nuria1110 nuria1110 merged commit fa5a1ca into master Nov 25, 2024
25 checks passed
@nuria1110 nuria1110 deleted the FE-6909 branch November 25, 2024 12:53
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 144.9.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Full screen menu component with max-width set has extra top and bottom padding
5 participants