Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full screen menu component with max-width set has extra top and bottom padding #7078

Closed
1 task done
szeyingyau opened this issue Nov 18, 2024 · 4 comments · Fixed by #7088
Closed
1 task done

Full screen menu component with max-width set has extra top and bottom padding #7078

szeyingyau opened this issue Nov 18, 2024 · 4 comments · Fixed by #7088
Labels
Bug On Backlog released Squad Nebula

Comments

@szeyingyau
Copy link
Contributor

szeyingyau commented Nov 18, 2024 •
edited
Loading

Description

When a menu has a href and max-width set onto it, there's extra top and bottom padding added to the menu item

Reproduction

https://stackblitz.com/edit/parsium-carbon-starter-lxdwbp?file=src%2FApp.tsx

Steps to reproduce

No response

JIRA ticket numbers (Sage only)

SBS-115109

Suggested solution

No response

Carbon version

144.0.0

Design tokens version

4.29.0

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@szeyingyau szeyingyau added Bug triage Triage Required labels Nov 18, 2024
@Parsium
Copy link
Contributor

Parsium commented Nov 19, 2024

FE-6909

@Parsium Parsium added On Backlog and removed triage Triage Required labels Nov 19, 2024
@nicktitchmarsh
Copy link
Contributor

@szeyingyau Is there a reason maxWidth is being set on these elements when there is no effect on the width as all children are set to 100% for MenuFullScreen?

@szeyingyau
Copy link
Contributor Author

szeyingyau commented Nov 20, 2024 •
edited
Loading

@nicktitchmarsh this is because we have the maxWidth being shared/re-used in both the Menu and the MenuFullScreen components

@nuria1110 nuria1110 mentioned this issue Nov 21, 2024
Merged
14 tasks
carbonci pushed a commit that referenced this issue Nov 25, 2024
@semantic-release-bot @carbonci
chore(release): 144.9.3
1d4e851 
### [144.9.3](v144.9.2...v144.9.3) (2024-11-25)

### Bug Fixes

* **menu-item:** ensure consistent padding within menu-full-screen ([0f61867](0f61867)), closes [#7078](#7078)
@carbonci
Copy link
Collaborator

🎉 This issue has been resolved in version 144.9.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug On Backlog released Squad Nebula
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(menu-item): ensure consistent padding within menu-full-screen Sage/carbon
4 participants
@Parsium @carbonci @nicktitchmarsh @szeyingyau