-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IBCDPE-430] Remove the top level array in the configuration files #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! This definitely cleans up the code in a bunch of places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛸 LGTM! Will wait for the other PR to merge all of it in.
…y_repeated_yaml [IBCDPE-430] Support shared source file definitions in config
🎉 All dependencies have been resolved ! |
Problem:
The way that the configuration files are currently set up leads to configuration data being loaded into a list of dictionaries instead of a simple dictionary. This leads to the need for the
utils._find_config_by_name
function to exist.Solution:
Change the configuration files so that the data is loaded as a simple dictionary.
Note:
The changes to include more YAML anchors in the configuration files will be made in #99 (WIP)
depends on #99