Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBCDPE-430] Remove the top level array in the configuration files #98

Merged
merged 14 commits into from
Dec 4, 2023

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Nov 27, 2023

Problem:

The way that the configuration files are currently set up leads to configuration data being loaded into a list of dictionaries instead of a simple dictionary. This leads to the need for the utils._find_config_by_name function to exist.

Solution:

Change the configuration files so that the data is loaded as a simple dictionary.

Note:
The changes to include more YAML anchors in the configuration files will be made in #99 (WIP)

depends on #99

@BWMac BWMac changed the title [IBCDPE-430] Support shared source file definitions in config [IBCDPE-430] Remove the top level array in the configuration files Nov 27, 2023
@BWMac BWMac marked this pull request as ready for review November 27, 2023 21:00
Copy link
Contributor

@jaclynbeck-sage jaclynbeck-sage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This definitely cleans up the code in a bunch of places.

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛸 LGTM! Will wait for the other PR to merge all of it in.

BWMac and others added 2 commits November 27, 2023 20:37
…y_repeated_yaml

[IBCDPE-430] Support shared source file definitions in config
Copy link

dpulls bot commented Dec 1, 2023

🎉 All dependencies have been resolved !

@BWMac BWMac merged commit a6a59b2 into dev Dec 4, 2023
7 checks passed
@BWMac BWMac deleted the bwmac/IBCDPE-430/config_update branch December 4, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants