Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AG-1161 Updated gene_info transform with renamed columns #88

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

jaclynbeck-sage
Copy link
Contributor

@jaclynbeck-sage jaclynbeck-sage commented Aug 23, 2023

This addresses AG-1161: multiple columns in the gene_info transform needed to be updated to use snake case or have more precise names. Where possible I used column_rename to accomplish the renaming and only updated the transform when it directly used or created the old name inside the transform.

This comment in the JIRA task lists what changed in order to rename each field.

@jaclynbeck-sage jaclynbeck-sage marked this pull request as ready for review August 24, 2023 02:35
Copy link
Contributor

@JessterB JessterB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jaclynbeck-sage jaclynbeck-sage merged commit c51103a into dev Aug 24, 2023
@jaclynbeck-sage jaclynbeck-sage deleted the jbeck/AG-1161/gene_info_field_changes branch August 24, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants