Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests and test input/output for the team_info transform #77

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

jaclynbeck-sage
Copy link
Contributor

@jaclynbeck-sage jaclynbeck-sage commented Jun 12, 2023

This test has 4 test cases, all of which should pass. There are no failure cases for this transform, as the transform is simple and doesn't care what the values are in each column. Since the data in the original team info source files is hand-curated and small, we assume that the contents of each column have been validated by the person curating the file, prior to the transform.

I made the test files to have values with a few properties, some of which are not explicitly tested by this test but may be useful in future:

  • missing a value in various columns
  • punctuation in the team names and people names
  • special characters in the URL fields (which I verified made it through standardize_values intact)
  • One team with multiple isprincipalinvestigator TRUE values (which happens in the real files)

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @jaclynbeck-sage! Let us know if you have feedback about the framework!

Copy link
Contributor

@BWMac BWMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@JessterB JessterB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jaclynbeck-sage jaclynbeck-sage merged commit c49b13e into dev Jun 12, 2023
@jaclynbeck-sage jaclynbeck-sage deleted the AG-1149_transform_team_info_testing branch June 12, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants